chrome/browser/ui/autofill/autofill_popup_controller_impl.cc - Issue 575283003: mac: Don't show access Address Book prompt if user has any Autofill state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

Issue 575283003: mac: Don't show access Address Book prompt if user has any Autofill state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix another unit test. Fix some broken (unused) logic in that unit test. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_manager_unittest.cc » ('j') | components/autofill/core/browser/autofill_manager_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc b/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

index ae0a5f29771f936724431102b85990b3476c863d..b9458b8a2df0766cc3b952086cf88255c39be762 100644

--- a/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

+++ b/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

@@ -530,7 +530,8 @@ bool AutofillPopupControllerImpl::HasSuggestions() {

(identifiers_[0] > 0 ||

identifiers_[0] == POPUP_ITEM_ID_AUTOCOMPLETE_ENTRY ||

identifiers_[0] == POPUP_ITEM_ID_PASSWORD_ENTRY ||

- identifiers_[0] == POPUP_ITEM_ID_DATALIST_ENTRY);

+ identifiers_[0] == POPUP_ITEM_ID_DATALIST_ENTRY ||

+ identifiers_[0] == POPUP_ITEM_ID_MAC_ACCESS_CONTACTS);

}

void AutofillPopupControllerImpl::SetValues(