mac: Don't show access Address Book prompt if user has any Autofill state.

components/autofill/core/browser/autofill_manager_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/format_macros.h"
 #include "base/memory/ref_counted.h"
@@ skipping 77 matching lines @@
   }
 
   void AddCreditCard(CreditCard* credit_card) {
     credit_cards_.push_back(credit_card);
   }
 
   virtual void RemoveByGUID(const std::string& guid) OVERRIDE {
     CreditCard* credit_card = GetCreditCardWithGUID(guid.c_str());
     if (credit_card) {
       credit_cards_.erase(
-          std::remove(credit_cards_.begin(), credit_cards_.end(), credit_card),

[erikchen, 2014/09/18 21:02:54]

This logic is incorrect. std::remove and erase() both remove elements from the
vector.

-          credit_cards_.end());
+          std::find(credit_cards_.begin(), credit_cards_.end(), credit_card));
     }
 
     AutofillProfile* profile = GetProfileWithGUID(guid.c_str());
     if (profile) {
       web_profiles_.erase(
-          std::remove(web_profiles_.begin(), web_profiles_.end(), profile),
-          web_profiles_.end());
+          std::find(web_profiles_.begin(), web_profiles_.end(), profile));
     }
   }
 
   // Do nothing (auxiliary profiles will be created in
   // CreateTestAuxiliaryProfile).
   virtual void LoadAuxiliaryProfiles(bool record_metrics) const OVERRIDE {}
 
   void ClearAutofillProfiles() {
     web_profiles_.clear();
   }
@@ skipping 2663 matching lines @@
   EXPECT_TRUE(autofill_manager_->GetProfileWithGUID(guid.c_str()));
 }
 
 #if defined(OS_MACOSX) && !defined(OS_IOS)
 TEST_F(AutofillManagerTest, AccessAddressBookPrompt) {
   FormData form;
   test::CreateTestAddressFormData(&form);
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
   FormFieldData& field = form.fields[0];
+  field.should_autocomplete = true;
+
+  // A profile already exists.
+  EXPECT_FALSE(
+      autofill_manager_->ShouldShowAccessAddressBookSuggestion(form, field));
+
+  // Remove all profiles.
+  personal_data_.ClearAutofillProfiles();
+  EXPECT_TRUE(
+      autofill_manager_->ShouldShowAccessAddressBookSuggestion(form, field));
 
   field.should_autocomplete = false;
   EXPECT_FALSE(
       autofill_manager_->ShouldShowAccessAddressBookSuggestion(form, field));
-
-  field.should_autocomplete = true;
-  EXPECT_TRUE(
-      autofill_manager_->ShouldShowAccessAddressBookSuggestion(form, field));
 }
 #endif  // defined(OS_MACOSX) && !defined(OS_IOS)
 
 namespace {
 
 class MockAutofillClient : public TestAutofillClient {
  public:
   MockAutofillClient() {}
 
   virtual ~MockAutofillClient() {}
@@ skipping 26 matching lines @@
   test::CreateTestAddressFormData(&form);
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
   const FormFieldData& field = form.fields[0];
   GetAutofillSuggestions(form, field);  // should call the delegate's OnQuery()
 
   EXPECT_TRUE(external_delegate_->on_query_seen());
 }
 
 }  // namespace autofill