Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Unified Diff: Source/core/css/CSSPrimitiveValueMappings.h

Issue 57493002: Remove 'alphabetic' value from text-underline-position (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/CSSPrimitiveValueMappings.h
diff --git a/Source/core/css/CSSPrimitiveValueMappings.h b/Source/core/css/CSSPrimitiveValueMappings.h
index 2b293fa6b130f5a7aab7bc4bba7faadd92f68bcf..20c0b8ce0d89f55215488e1aeacb865718ee92f2 100644
--- a/Source/core/css/CSSPrimitiveValueMappings.h
+++ b/Source/core/css/CSSPrimitiveValueMappings.h
@@ -2505,9 +2505,6 @@ template<> inline CSSPrimitiveValue::CSSPrimitiveValue(TextUnderlinePosition e)
case TextUnderlinePositionAuto:
m_value.valueID = CSSValueAuto;
break;
- case TextUnderlinePositionAlphabetic:
- m_value.valueID = CSSValueAlphabetic;
- break;
case TextUnderlinePositionUnder:
m_value.valueID = CSSValueUnder;
break;
@@ -2518,20 +2515,17 @@ template<> inline CSSPrimitiveValue::CSSPrimitiveValue(TextUnderlinePosition e)
template<> inline CSSPrimitiveValue::operator TextUnderlinePosition() const
{
+ // FIXME: Implement support for 'left' and 'right' values.
ASSERT(isValueID());
switch (m_value.valueID) {
case CSSValueAuto:
return TextUnderlinePositionAuto;
- case CSSValueAlphabetic:
- return TextUnderlinePositionAlphabetic;
case CSSValueUnder:
return TextUnderlinePositionUnder;
default:
break;
}
- // FIXME: Implement support for 'under left' and 'under right' values.
Julien - ping for review 2013/11/04 16:06:43 What's wrong with this comment that you need to mo
abinader 2013/11/04 16:38:02 I thought it would make more sense by having the c
-
ASSERT_NOT_REACHED();
return TextUnderlinePositionAuto;
}

Powered by Google App Engine
This is Rietveld 408576698