Chromium Code Reviews| Index: Source/core/rendering/InlineTextBox.cpp |
| diff --git a/Source/core/rendering/InlineTextBox.cpp b/Source/core/rendering/InlineTextBox.cpp |
| index f9082487d529c95ed2706aa2e3838e306f012d84..f6450b3aeee95a81f3df38154dff95e2684cc5fe 100644 |
| --- a/Source/core/rendering/InlineTextBox.cpp |
| +++ b/Source/core/rendering/InlineTextBox.cpp |
| @@ -925,9 +925,9 @@ static int computeUnderlineOffset(const TextUnderlinePosition underlinePosition, |
| // According to the specification TextUnderlinePositionAuto should default to 'alphabetic' for horizontal text |
|
Julien - ping for review
2013/11/04 16:06:43
This comment should be updated as 'alphabetic' was
abinader
2013/11/04 16:38:02
Ack!
|
| // and to 'under Left' for vertical text (e.g. japanese). We support only horizontal text for now. |
| switch (underlinePosition) { |
| - case TextUnderlinePositionAlphabetic: |
| case TextUnderlinePositionAuto: |
| - return fontMetrics.ascent() + gap; // Position underline near the alphabetic baseline. |
| + // Position underline near the alphabetic baseline. |
| + return fontMetrics.ascent() + gap; |
| case TextUnderlinePositionUnder: { |
| // Position underline relative to the under edge of the lowest element's content box. |
| const float offset = inlineTextBox->root()->maxLogicalTop() - inlineTextBox->logicalTop(); |