Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Unified Diff: Source/core/css/CSSParser-in.cpp

Issue 57493002: Remove 'alphabetic' value from text-underline-position (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/CSSParser-in.cpp
diff --git a/Source/core/css/CSSParser-in.cpp b/Source/core/css/CSSParser-in.cpp
index a63d5b7043425d4dfc131493b100dad8254f18ad..6cdd0b6ce539d6b6b105993b459ef35aba148028 100644
--- a/Source/core/css/CSSParser-in.cpp
+++ b/Source/core/css/CSSParser-in.cpp
@@ -2182,7 +2182,8 @@ bool CSSParser::parseValue(CSSPropertyID propId, bool important)
break;
case CSSPropertyTextUnderlinePosition:
- // auto | alphabetic | under
+ // FIXME: Implement support for 'left' and 'right' values.
Julien - ping for review 2013/11/04 16:06:43 This FIXME is too far from the implementation and
abinader 2013/11/04 16:38:02 OK, will remove that.
+ // auto | under | inherit
if (RuntimeEnabledFeatures::css3TextDecorationsEnabled())
return parseTextUnderlinePosition(important);
return false;
@@ -9134,13 +9135,10 @@ bool CSSParser::parseTextDecoration(CSSPropertyID propId, bool important)
bool CSSParser::parseTextUnderlinePosition(bool important)
{
- // The text-underline-position property has sintax "auto | alphabetic | [ under || [ left | right ] ]".
- // However, values 'left' and 'right' are not implemented yet, so we will parse sintax
- // "auto | alphabetic | under" for now.
Julien - ping for review 2013/11/04 16:06:43 I would rather keep this comment so that we know w
abinader 2013/11/04 16:38:02 Ack!
+ // FIXME: Implement support for 'left' and 'right' values.
CSSParserValue* value = m_valueList->current();
switch (value->id) {
case CSSValueAuto:
- case CSSValueAlphabetic:
case CSSValueUnder:
if (m_valueList->next())
return false;

Powered by Google App Engine
This is Rietveld 408576698