Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Side by Side Diff: Source/core/css/CSSPrimitiveValueMappings.h

Issue 57493002: Remove 'alphabetic' value from text-underline-position (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Alexey Proskuryakov <ap@nypop.com>. 2 * Copyright (C) 2007 Alexey Proskuryakov <ap@nypop.com>.
3 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 3 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
4 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 4 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
5 * Copyright (C) 2009 Jeff Schiller <codedread@gmail.com> 5 * Copyright (C) 2009 Jeff Schiller <codedread@gmail.com>
6 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
7 * 7 *
8 * Redistribution and use in source and binary forms, with or without 8 * Redistribution and use in source and binary forms, with or without
9 * modification, are permitted provided that the following conditions 9 * modification, are permitted provided that the following conditions
10 * are met: 10 * are met:
(...skipping 2487 matching lines...) Expand 10 before | Expand all | Expand 10 after
2498 } 2498 }
2499 2499
2500 template<> inline CSSPrimitiveValue::CSSPrimitiveValue(TextUnderlinePosition e) 2500 template<> inline CSSPrimitiveValue::CSSPrimitiveValue(TextUnderlinePosition e)
2501 : CSSValue(PrimitiveClass) 2501 : CSSValue(PrimitiveClass)
2502 { 2502 {
2503 m_primitiveUnitType = CSS_VALUE_ID; 2503 m_primitiveUnitType = CSS_VALUE_ID;
2504 switch (e) { 2504 switch (e) {
2505 case TextUnderlinePositionAuto: 2505 case TextUnderlinePositionAuto:
2506 m_value.valueID = CSSValueAuto; 2506 m_value.valueID = CSSValueAuto;
2507 break; 2507 break;
2508 case TextUnderlinePositionAlphabetic:
2509 m_value.valueID = CSSValueAlphabetic;
2510 break;
2511 case TextUnderlinePositionUnder: 2508 case TextUnderlinePositionUnder:
2512 m_value.valueID = CSSValueUnder; 2509 m_value.valueID = CSSValueUnder;
2513 break; 2510 break;
2514 } 2511 }
2515 2512
2516 // FIXME: Implement support for 'under left' and 'under right' values. 2513 // FIXME: Implement support for 'under left' and 'under right' values.
2517 } 2514 }
2518 2515
2519 template<> inline CSSPrimitiveValue::operator TextUnderlinePosition() const 2516 template<> inline CSSPrimitiveValue::operator TextUnderlinePosition() const
2520 { 2517 {
2518 // FIXME: Implement support for 'left' and 'right' values.
2521 ASSERT(isValueID()); 2519 ASSERT(isValueID());
2522 switch (m_value.valueID) { 2520 switch (m_value.valueID) {
2523 case CSSValueAuto: 2521 case CSSValueAuto:
2524 return TextUnderlinePositionAuto; 2522 return TextUnderlinePositionAuto;
2525 case CSSValueAlphabetic:
2526 return TextUnderlinePositionAlphabetic;
2527 case CSSValueUnder: 2523 case CSSValueUnder:
2528 return TextUnderlinePositionUnder; 2524 return TextUnderlinePositionUnder;
2529 default: 2525 default:
2530 break; 2526 break;
2531 } 2527 }
2532 2528
2533 // FIXME: Implement support for 'under left' and 'under right' values.
Julien - ping for review 2013/11/04 16:06:43 What's wrong with this comment that you need to mo
abinader 2013/11/04 16:38:02 I thought it would make more sense by having the c
2534
2535 ASSERT_NOT_REACHED(); 2529 ASSERT_NOT_REACHED();
2536 return TextUnderlinePositionAuto; 2530 return TextUnderlinePositionAuto;
2537 } 2531 }
2538 2532
2539 template<> inline CSSPrimitiveValue::CSSPrimitiveValue(ETextSecurity e) 2533 template<> inline CSSPrimitiveValue::CSSPrimitiveValue(ETextSecurity e)
2540 : CSSValue(PrimitiveClass) 2534 : CSSValue(PrimitiveClass)
2541 { 2535 {
2542 m_primitiveUnitType = CSS_VALUE_ID; 2536 m_primitiveUnitType = CSS_VALUE_ID;
2543 switch (e) { 2537 switch (e) {
2544 case TSNONE: 2538 case TSNONE:
(...skipping 2413 matching lines...) Expand 10 before | Expand all | Expand 10 after
4958 break; 4952 break;
4959 } 4953 }
4960 4954
4961 ASSERT_NOT_REACHED(); 4955 ASSERT_NOT_REACHED();
4962 return TouchActionDelayNone; 4956 return TouchActionDelayNone;
4963 } 4957 }
4964 4958
4965 } 4959 }
4966 4960
4967 #endif 4961 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698