Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(25)

Issue 5741001: Even more virtual method deinlining. (Closed)

Created:
7 years, 8 months ago by Elliot Glaysher
Modified:
7 years, 3 months ago
CC:
chromium-reviews, vrk (LEFT CHROMIUM), annacc, stuartmorgan+watch_chromium.org, dhollowa, ncarter (slow), fbarchard, idana, Erik does not do reviews, ben+cc_chromium.org, jam, dmac, apatrick_chromium, darin-cc_chromium.org, garykac, brettw-cc_chromium.org, tim (not reviewing), ddorwin+watch_chromium.org, Raghu Simha, cbentzel+watch_chromium.org, pam+watch_chromium.org, awong, James Hawkins, scherkus (not reviewing), michaeln, sjl, Sergey Ulanov, Alpha Left Google, Aaron Boodman, acolwell GONE FROM CHROMIUM, rdsmith+dwatch_chromium.org, PaweĊ‚ Hajdan Jr., Ilya Sherman
Visibility:
Public.

Description

Even more virtual method deinlining. BUG=none TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69041

Patch Set 1 #

Patch Set 2 : Rebase (and pray for windows fix) #

Patch Set 3 : Fix cf link by removing changes to first_run.{cc,h} #

Patch Set 4 : Rebase (windows) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+949 lines, -407 lines) Patch
M app/app_base.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M app/multi_animation.h View 1 chunk +1 line, -1 line 0 comments Download
M app/multi_animation.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M app/tree_model.h View 3 chunks +2 lines, -6 lines 0 comments Download
A app/tree_model.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_gtk.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_popup_view_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/autofill/credit_card.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/credit_card.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/autofill/fax_number.h View 1 chunk +9 lines, -21 lines 0 comments Download
A chrome/browser/autofill/fax_number.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M chrome/browser/autofill/form_field.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/form_field.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/autofill/home_address.h View 1 chunk +10 lines, -29 lines 0 comments Download
A chrome/browser/autofill/home_address.cc View 1 chunk +41 lines, -0 lines 0 comments Download
M chrome/browser/autofill/name_field.h View 2 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/autofill/name_field.cc View 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/autofill/personal_data_manager.h View 1 chunk +3 lines, -7 lines 0 comments Download
M chrome/browser/autofill/personal_data_manager.cc View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/bookmarks/base_bookmark_model_observer.h View 1 chunk +8 lines, -21 lines 0 comments Download
A chrome/browser/bookmarks/base_bookmark_model_observer.cc View 1 chunk +51 lines, -0 lines 0 comments Download
M chrome/browser/cookies_tree_model.h View 13 chunks +28 lines, -80 lines 0 comments Download
M chrome/browser/cookies_tree_model.cc View 14 chunks +116 lines, -0 lines 0 comments Download
M chrome/browser/debugger/devtools_client_host.h View 1 chunk +2 lines, -7 lines 0 comments Download
A chrome/browser/debugger/devtools_client_host.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/browser/debugger/devtools_remote_listen_socket.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/debugger/devtools_remote_listen_socket.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/debugger/devtools_window.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/debugger/devtools_window.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/history_ui.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/dom_ui/history_ui.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/download/download_shelf.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_shelf.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_host.h View 3 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_host.cc View 1 2 3 3 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extensions_service.h View 3 chunks +5 lines, -11 lines 0 comments Download
M chrome/browser/extensions/extensions_service.cc View 1 2 3 2 chunks +20 lines, -0 lines 0 comments Download
M chrome/browser/gtk/browser_actions_toolbar_gtk.h View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/gtk/browser_actions_toolbar_gtk.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/browser/plugin_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugin_process_host.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host.h View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/sidebar/sidebar_container.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sidebar/sidebar_container.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/sync/engine/model_changing_syncer_command.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/sync/engine/model_changing_syncer_command.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/sync/engine/net/server_connection_manager.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/sync/engine/net/server_connection_manager.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/sync/engine/syncer_thread.h View 2 chunks +5 lines, -15 lines 0 comments Download
M chrome/browser/sync/engine/syncer_thread.cc View 2 chunks +20 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/session_model_associator.h View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/sync/glue/session_model_associator.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/ui_model_worker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/ui_model_worker.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/tab_closeable_state_watcher.h View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/tab_closeable_state_watcher.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/background_contents.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/background_contents.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/infobar_delegate.h View 6 chunks +23 lines, -56 lines 0 comments Download
M chrome/browser/tab_contents/infobar_delegate.cc View 5 chunks +96 lines, -0 lines 0 comments Download
M chrome/browser/themes/browser_theme_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/themes/browser_theme_provider.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_modal_dialogs/app_modal_dialog.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_modal_dialogs/app_modal_dialog.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/utility_process_host.h View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/utility_process_host.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 3 chunks +4 lines, -0 lines 0 comments Download
M chrome/common/json_pref_store.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/json_pref_store.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/metrics_helpers.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/common/metrics_helpers.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/service/service_utility_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/service_utility_process_host.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.h View 1 chunk +1 line, -3 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/shader_translator.h View 1 chunk +4 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/shader_translator.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M media/filters/video_renderer_base.h View 1 chunk +1 line, -3 lines 0 comments Download
M media/filters/video_renderer_base.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/base/host_resolver_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M net/base/host_resolver_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/http/http_auth_controller.h View 1 chunk +2 lines, -6 lines 0 comments Download
M net/http/http_auth_controller.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M net/http/http_proxy_client_socket.h View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_proxy_client_socket.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/http/http_proxy_client_socket_pool.h View 2 chunks +3 lines, -9 lines 0 comments Download
M net/http/http_proxy_client_socket_pool.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M net/socket/ssl_client_socket_pool.h View 2 chunks +3 lines, -9 lines 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M net/url_request/url_request_http_job.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_http_job.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M ppapi/proxy/image_data.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/image_data.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ppapi/proxy/plugin_resource.h View 4 chunks +4 lines, -4 lines 0 comments Download
M ppapi/proxy/plugin_resource.cc View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/jingle_glue/ssl_socket_adapter.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/jingle_glue/ssl_socket_adapter.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M skia/ext/vector_platform_device_linux.h View 1 chunk +3 lines, -5 lines 0 comments Download
M skia/ext/vector_platform_device_linux.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M webkit/appcache/appcache_url_request_job.h View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M webkit/appcache/appcache_url_request_job.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/media/buffered_data_source.h View 1 chunk +5 lines, -5 lines 0 comments Download
M webkit/glue/media/buffered_data_source.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M webkit/glue/plugins/pepper_graphics_2d.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/plugins/pepper_graphics_2d.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/plugins/pepper_graphics_3d.h View 1 chunk +1 line, -3 lines 0 comments Download
M webkit/glue/plugins/pepper_graphics_3d.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/plugins/pepper_image_data.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/plugins/pepper_image_data.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/plugins/pepper_resource.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M webkit/glue/plugins/pepper_resource.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M webkit/glue/plugins/pepper_transport.h View 1 chunk +1 line, -3 lines 0 comments Download
M webkit/glue/plugins/pepper_transport.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/plugins/pepper_var.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/glue/plugins/pepper_var.cc View 3 chunks +12 lines, -0 lines 0 comments Download
M webkit/glue/plugins/plugin_stream.h View 1 chunk +1 line, -3 lines 0 comments Download
M webkit/glue/plugins/plugin_stream.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/webmediaplayer_impl.h View 1 chunk +2 lines, -6 lines 0 comments Download
M webkit/glue/webmediaplayer_impl.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Elliot Glaysher
Boring patch seeks rubberstamp.
7 years, 8 months ago (2010-12-09 20:15:15 UTC) #1
Peter Kasting
I mentioned to Elliot that I'm not comfortable with some of the deinlining that's happening ...
7 years, 8 months ago (2010-12-09 20:46:45 UTC) #2
Elliot Glaysher
On 2010/12/09 20:46:45, Peter Kasting wrote: > I mentioned to Elliot that I'm not comfortable ...
7 years, 8 months ago (2010-12-09 22:54:19 UTC) #3
Peter Kasting
I withdraw my objections. I disagree in passing that "we're not supposed to supply default ...
7 years, 8 months ago (2010-12-09 23:13:39 UTC) #4
Elliot Glaysher
SUPER PING PPL.
7 years, 8 months ago (2010-12-13 19:28:21 UTC) #5
James Hawkins
7 years, 8 months ago (2010-12-13 19:35:10 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698