Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Side by Side Diff: chrome/browser/sidebar/sidebar_container.h

Issue 5741001: Even more virtual method deinlining. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase (windows) Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SIDEBAR_SIDEBAR_CONTAINER_H_ 5 #ifndef CHROME_BROWSER_SIDEBAR_SIDEBAR_CONTAINER_H_
6 #define CHROME_BROWSER_SIDEBAR_SIDEBAR_CONTAINER_H_ 6 #define CHROME_BROWSER_SIDEBAR_SIDEBAR_CONTAINER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 virtual void AddNewContents(TabContents* source, 98 virtual void AddNewContents(TabContents* source,
99 TabContents* new_contents, 99 TabContents* new_contents,
100 WindowOpenDisposition disposition, 100 WindowOpenDisposition disposition,
101 const gfx::Rect& initial_pos, 101 const gfx::Rect& initial_pos,
102 bool user_gesture) {} 102 bool user_gesture) {}
103 virtual void ActivateContents(TabContents* contents) {} 103 virtual void ActivateContents(TabContents* contents) {}
104 virtual void DeactivateContents(TabContents* contents) {} 104 virtual void DeactivateContents(TabContents* contents) {}
105 virtual void LoadingStateChanged(TabContents* source) {} 105 virtual void LoadingStateChanged(TabContents* source) {}
106 virtual void CloseContents(TabContents* source) {} 106 virtual void CloseContents(TabContents* source) {}
107 virtual void MoveContents(TabContents* source, const gfx::Rect& pos) {} 107 virtual void MoveContents(TabContents* source, const gfx::Rect& pos) {}
108 virtual bool IsPopup(const TabContents* source) const { return false; } 108 virtual bool IsPopup(const TabContents* source) const;
109 virtual void URLStarredChanged(TabContents* source, bool starred) {} 109 virtual void URLStarredChanged(TabContents* source, bool starred) {}
110 virtual void UpdateTargetURL(TabContents* source, const GURL& url) {} 110 virtual void UpdateTargetURL(TabContents* source, const GURL& url) {}
111 virtual void ToolbarSizeChanged(TabContents* source, bool is_animating) {} 111 virtual void ToolbarSizeChanged(TabContents* source, bool is_animating) {}
112 112
113 // Contents of the tab this sidebar is linked to. 113 // Contents of the tab this sidebar is linked to.
114 TabContents* tab_; 114 TabContents* tab_;
115 115
116 // Sidebar's content id. There might be more than one sidebar liked to each 116 // Sidebar's content id. There might be more than one sidebar liked to each
117 // particular tab and they are identified by their unique content id. 117 // particular tab and they are identified by their unique content id.
118 const std::string content_id_; 118 const std::string content_id_;
(...skipping 11 matching lines...) Expand all
130 scoped_ptr<SkBitmap> icon_; 130 scoped_ptr<SkBitmap> icon_;
131 131
132 // Sidebar's title, displayed as a tooltip for sidebar's mini tab. 132 // Sidebar's title, displayed as a tooltip for sidebar's mini tab.
133 string16 title_; 133 string16 title_;
134 134
135 DISALLOW_COPY_AND_ASSIGN(SidebarContainer); 135 DISALLOW_COPY_AND_ASSIGN(SidebarContainer);
136 }; 136 };
137 137
138 #endif // CHROME_BROWSER_SIDEBAR_SIDEBAR_CONTAINER_H_ 138 #endif // CHROME_BROWSER_SIDEBAR_SIDEBAR_CONTAINER_H_
139 139
OLDNEW
« no previous file with comments | « chrome/browser/renderer_host/render_widget_host.cc ('k') | chrome/browser/sidebar/sidebar_container.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698