Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 572873002: Declaring the weak_ptr_factory in proper order. (Closed)

Created:
6 years, 3 months ago by Anand Ratn (left samsung)
Modified:
6 years, 3 months ago
Reviewers:
oshima
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Declaring the weak_ptr_factory in proper order. Cleaning up weak_ptr_factory destruction order in "src/chrome/browser/chromeos" module. WeakPtrFactory should remain the last member so it'll be destroyed and invalidate its weak pointers before any other members are destroyed. BUG=303818 Committed: https://crrev.com/d35b99c4d56ee98508103fc8a832f57f02eb154a Cr-Commit-Position: refs/heads/master@{#295923}

Patch Set 1 #

Patch Set 2 : build break fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -34 lines) Patch
M chrome/browser/chromeos/login/ui/login_display_host_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/app_pack_updater.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/app_pack_updater.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/device_status_collector.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_status_collector.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/settings/session_manager_operation.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/settings/session_manager_operation.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/system/automatic_reboot_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/ui/idle_logout_dialog_view.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Anand Ratn (left samsung)
oshima@chromium.org : Please review changes in src/chrome/browser/chromeos module.
6 years, 3 months ago (2014-09-16 07:18:42 UTC) #2
oshima
lgtm
6 years, 3 months ago (2014-09-16 17:17:49 UTC) #3
Anand Ratn (left samsung)
On 2014/09/16 17:17:49, oshima wrote: > lgtm Thanks for the review oshima.
6 years, 3 months ago (2014-09-17 03:59:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/572873002/1
6 years, 3 months ago (2014-09-17 03:59:44 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/15038)
6 years, 3 months ago (2014-09-17 04:37:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/572873002/20001
6 years, 3 months ago (2014-09-17 04:49:58 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/15055)
6 years, 3 months ago (2014-09-17 05:55:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/572873002/20001
6 years, 3 months ago (2014-09-22 03:49:04 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 5b06b8c3085da8ff78d0f0ce9da5312b8b792bda
6 years, 3 months ago (2014-09-22 04:26:18 UTC) #15
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 04:26:52 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d35b99c4d56ee98508103fc8a832f57f02eb154a
Cr-Commit-Position: refs/heads/master@{#295923}

Powered by Google App Engine
This is Rietveld 408576698