Declaring the weak_ptr_factory in proper order.

chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
 #include "base/files/file_util.h"
@@ skipping 74 matching lines @@
 
  private:
   // Checks whether the load operations from the legacy caches completed. If so,
   // fires the appropriate notification.
   void CheckLoadFinished();
 
   // Maps a disk cache LoadResult to a CloudPolicyStore::Status.
   static CloudPolicyStore::Status TranslateLoadResult(
       UserPolicyDiskCache::LoadResult result);
 
-  base::WeakPtrFactory<LegacyPolicyCacheLoader> weak_factory_;
-
   scoped_refptr<UserPolicyTokenLoader> token_loader_;
   scoped_refptr<UserPolicyDiskCache> policy_cache_;
 
   std::string dm_token_;
   std::string device_id_;
   bool has_policy_;
   scoped_ptr<em::PolicyFetchResponse> policy_;
   CloudPolicyStore::Status status_;
 
   Callback callback_;
 
+  base::WeakPtrFactory<LegacyPolicyCacheLoader> weak_factory_;
+
   DISALLOW_COPY_AND_ASSIGN(LegacyPolicyCacheLoader);
 };
 
 LegacyPolicyCacheLoader::LegacyPolicyCacheLoader(
     const base::FilePath& token_cache_file,
     const base::FilePath& policy_cache_file,
     scoped_refptr<base::SequencedTaskRunner> background_task_runner)
-    : weak_factory_(this),
-      has_policy_(false),
-      status_(CloudPolicyStore::STATUS_OK) {
+    : has_policy_(false),
+      status_(CloudPolicyStore::STATUS_OK),
+      weak_factory_(this) {
   token_loader_ = new UserPolicyTokenLoader(weak_factory_.GetWeakPtr(),
                                             token_cache_file,
                                             background_task_runner);
   policy_cache_ = new UserPolicyDiskCache(weak_factory_.GetWeakPtr(),
                                           policy_cache_file,
                                           background_task_runner);
 }
 
 LegacyPolicyCacheLoader::~LegacyPolicyCacheLoader() {}
 
@@ skipping 51 matching lines @@
     scoped_refptr<base::SequencedTaskRunner> background_task_runner,
     const std::string& username,
     const base::FilePath& user_policy_key_dir,
     const base::FilePath& legacy_token_cache_file,
     const base::FilePath& legacy_policy_cache_file)
     : UserCloudPolicyStoreBase(background_task_runner),
       cryptohome_client_(cryptohome_client),
       session_manager_client_(session_manager_client),
       username_(username),
       user_policy_key_dir_(user_policy_key_dir),
-      weak_factory_(this),
       legacy_cache_dir_(legacy_token_cache_file.DirName()),
       legacy_loader_(new LegacyPolicyCacheLoader(legacy_token_cache_file,
                                                  legacy_policy_cache_file,
                                                  background_task_runner)),
       legacy_caches_loaded_(false),
-      policy_key_loaded_(false) {}
+      policy_key_loaded_(false),
+      weak_factory_(this) {}
 
 UserCloudPolicyStoreChromeOS::~UserCloudPolicyStoreChromeOS() {}
 
 void UserCloudPolicyStoreChromeOS::Store(
     const em::PolicyFetchResponse& policy) {
   // Cancel all pending requests.
   weak_factory_.InvalidateWeakPtrs();
   scoped_ptr<em::PolicyFetchResponse> response(
       new em::PolicyFetchResponse(policy));
   EnsurePolicyKeyLoaded(
@@ skipping 356 matching lines @@
   const std::string empty_key = std::string();
   // The policy loaded from session manager need not be validated using the
   // verification key since it is secure, and since there may be legacy policy
   // data that was stored without a verification key. Hence passing an empty
   // value for the verification key.
   validator->ValidateSignature(
       policy_key_, empty_key, ExtractDomain(username_), allow_rotation);
   return validator.Pass();
 }
 }  // namespace policy