chrome/browser/chromeos/login/ui/login_display_host_impl.cc - Issue 572873002: Declaring the weak_ptr_factory in proper order.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/ui/login_display_host_impl.cc

Issue 572873002: Declaring the weak_ptr_factory in proper order. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: build break fixed Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/login/ui/login_display_host_impl.cc

diff --git a/chrome/browser/chromeos/login/ui/login_display_host_impl.cc b/chrome/browser/chromeos/login/ui/login_display_host_impl.cc

index ef282c472eae10d8935f8a7ec479cfb929845389..d4b3035c8d63fbeda5aa12c4d6c907fc9e1cc329 100644

--- a/chrome/browser/chromeos/login/ui/login_display_host_impl.cc

+++ b/chrome/browser/chromeos/login/ui/login_display_host_impl.cc

@@ -283,10 +283,10 @@ LoginDisplayHostImpl::LoginDisplayHostImpl(const gfx::Rect& background_bounds)

crash_count_(0),

restore_path_(RESTORE_UNKNOWN),

finalize_animation_type_(ANIMATION_WORKSPACE),

- animation_weak_ptr_factory_(this),

startup_sound_played_(false),

startup_sound_honors_spoken_feedback_(false),

- is_observing_keyboard_(false) {

+ is_observing_keyboard_(false),

+ animation_weak_ptr_factory_(this) {

DBusThreadManager::Get()->GetSessionManagerClient()->AddObserver(this);

CrasAudioHandler::Get()->AddAudioObserver(this);

if (keyboard::KeyboardController::GetInstance()) {