chrome/browser/chromeos/policy/device_status_collector.h - Issue 572873002: Declaring the weak_ptr_factory in proper order.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/device_status_collector.h

Issue 572873002: Declaring the weak_ptr_factory in proper order. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: build break fixed Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/policy/device_status_collector.h

diff --git a/chrome/browser/chromeos/policy/device_status_collector.h b/chrome/browser/chromeos/policy/device_status_collector.h

index d4f70fe40fb7b4e90acb5b63ebec0d840650595d..7a77b0febae6efe696226aa07b0b281799c2fec5 100644

--- a/chrome/browser/chromeos/policy/device_status_collector.h

+++ b/chrome/browser/chromeos/policy/device_status_collector.h

@@ -165,8 +165,6 @@ class DeviceStatusCollector : public CloudPolicyClient::StatusProvider {

chromeos::CrosSettings* cros_settings_;

- base::WeakPtrFactory<DeviceStatusCollector> weak_factory_;

// TODO(bartfab): Remove this once crbug.com/125931 is addressed and a proper

// way to mock geolocation exists.

LocationUpdateRequester location_update_requester_;

@@ -195,6 +193,8 @@ class DeviceStatusCollector : public CloudPolicyClient::StatusProvider {

scoped_ptr<chromeos::CrosSettings::ObserverSubscription>

users_subscription_;

+ base::WeakPtrFactory<DeviceStatusCollector> weak_factory_;

DISALLOW_COPY_AND_ASSIGN(DeviceStatusCollector);

};