Chromium Code Reviews

Issue 571863002: GN: Get //chrome/* mostly working on android (Closed)

Created:
6 years, 3 months ago by jamesr
Modified:
6 years, 3 months ago
Reviewers:
cjhopman, brettw
CC:
chromium-reviews, zea+watch_chromium.org, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org, cjhopman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

GN: Get //chrome/* mostly working on android This gets the //chrome subtree down to a fairly small number of build errors on Android. Most of the changes are making features not enabled on android like extensions and plugins properly guarded. This also adds a few jni targets and fixes up some bitrotted bits. R=brettw@chromium.org, cjhopman@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/2ed4d695d6cf2917fc0e52f767d629fbefa7a1f9

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Stats (+102 lines, -59 lines)
M BUILD.gn View 4 chunks +6 lines, -14 lines 0 comments
M build/config/BUILD.gn View 2 chunks +3 lines, -1 line 0 comments
M chrome/BUILD.gn View 4 chunks +11 lines, -5 lines 0 comments
M chrome/browser/BUILD.gn View 8 chunks +26 lines, -9 lines 0 comments
M chrome/browser/ui/BUILD.gn View 4 chunks +4 lines, -2 lines 0 comments
M chrome/common/BUILD.gn View 4 chunks +5 lines, -5 lines 0 comments
M chrome/renderer/BUILD.gn View 4 chunks +6 lines, -4 lines 0 comments
M chrome/utility/BUILD.gn View 1 chunk +1 line, -1 line 0 comments
M components/autofill/core/common/BUILD.gn View 1 chunk +0 lines, -8 lines 0 comments
M components/dom_distiller/core/BUILD.gn View 2 chunks +14 lines, -1 line 0 comments
M components/gcm_driver.gypi View 1 chunk +1 line, -0 lines 0 comments
M components/gcm_driver/BUILD.gn View 2 chunks +12 lines, -1 line 0 comments
M components/sessions/BUILD.gn View 1 chunk +1 line, -1 line 0 comments
M third_party/libaddressinput/BUILD.gn View 3 chunks +12 lines, -7 lines 0 comments

Messages

Total messages: 16 (5 generated)
jamesr
Remaining issues are some resources things I don't understand and some include path shenanagins in ...
6 years, 3 months ago (2014-09-15 05:50:22 UTC) #1
cjhopman
https://codereview.chromium.org/571863002/diff/1/chrome/browser/BUILD.gn File chrome/browser/BUILD.gn (right): https://codereview.chromium.org/571863002/diff/1/chrome/browser/BUILD.gn#newcode10 chrome/browser/BUILD.gn:10: # produces a conflict for the "grit" template so ...
6 years, 3 months ago (2014-09-15 17:23:08 UTC) #3
brettw
https://codereview.chromium.org/571863002/diff/1/chrome/browser/BUILD.gn File chrome/browser/BUILD.gn (right): https://codereview.chromium.org/571863002/diff/1/chrome/browser/BUILD.gn#newcode10 chrome/browser/BUILD.gn:10: # produces a conflict for the "grit" template so ...
6 years, 3 months ago (2014-09-15 18:11:10 UTC) #4
brettw
lgtm
6 years, 3 months ago (2014-09-15 18:13:29 UTC) #5
cjhopman
lgtm
6 years, 3 months ago (2014-09-15 21:55:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571863002/1
6 years, 3 months ago (2014-09-16 00:37:45 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/11156)
6 years, 3 months ago (2014-09-16 01:20:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571863002/20001
6 years, 3 months ago (2014-09-17 01:26:59 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/11458)
6 years, 3 months ago (2014-09-17 01:38:56 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/2ed4d695d6cf2917fc0e52f767d629fbefa7a1f9 Cr-Commit-Position: refs/heads/master@{#295231}
6 years, 3 months ago (2014-09-17 05:22:01 UTC) #15
jamesr
6 years, 3 months ago (2014-09-17 05:22:03 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 2ed4d69.

Powered by Google App Engine