Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: chrome/browser/BUILD.gn

Issue 571863002: GN: Get //chrome/* mostly working on android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/BUILD.gn ('k') | chrome/browser/ui/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/BUILD.gn
diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
index d5f7f467b514b5055aca6f22de6973bf3bb882b8..41283d710201d678706fef6bef0f27facceff47f 100644
--- a/chrome/browser/BUILD.gn
+++ b/chrome/browser/BUILD.gn
@@ -6,7 +6,13 @@ import("//build/config/crypto.gni")
import("//build/config/features.gni")
import("//build/config/ui.gni")
import("//components/nacl/nacl_defines.gni")
-import("//tools/grit/grit_rule.gni")
+# //build/config/android/rules.gni imports //tools/grit/grit_rule.gni, which
+# produces a conflict for the "grit" template so we have to only include one.
+if (is_android) {
+ import("//build/config/android/rules.gni")
+} else {
+ import("//tools/grit/grit_rule.gni")
+}
about_credits_file = "$target_gen_dir/about_credits.html"
additional_modules_list_file =
@@ -69,7 +75,6 @@ static_library("browser") {
"//components/os_crypt",
"//components/password_manager/core/browser",
"//components/password_manager/core/common",
- "//components/pdf/browser",
"//components/policy:policy_component",
"//components/precache/core",
"//components/query_parser",
@@ -263,7 +268,7 @@ static_library("browser") {
# ["debug_devtools==1", { TODO(GYP)
# "defines": [
# "DEBUG_DEVTOOLS=1",
- # ],
+ # }],
if (enable_configuration_policy) {
sources += rebase_path(
gypi_values.chrome_browser_policy_shared_with_ios_sources,
@@ -286,10 +291,7 @@ static_library("browser") {
sources += rebase_path(gypi_values.chrome_browser_policy_desktop_sources,
".", "//chrome")
}
- if (is_android || is_ios) {
- sources += rebase_path(gypi_values.chrome_browser_mobile_sources,
- ".", "//chrome")
- } else { # Non-mobile
+ if (!is_android && !is_ios) { # Non-mobile
deps += [
"//chrome/browser/policy:path_parser",
]
@@ -304,6 +306,7 @@ static_library("browser") {
sources += rebase_path(gypi_values.chrome_browser_plugins_sources,
".", "//chrome")
deps += [
+ "//components/pdf/browser",
"//ppapi:ppapi_ipc",
"//third_party/adobe/flash:flapper_version_h",
]
@@ -459,9 +462,9 @@ static_library("browser") {
sources += rebase_path(gypi_values.chrome_browser_android_sources,
".", "//chrome")
deps += [
+ ":jni_headers",
"//components/cdm/browser",
#"../components/components.gyp:web_contents_delegate_android", TODO(GYP)
- #"chrome_browser_jni_headers", TODO(GYP)
]
deps -= [
"//third_party/libaddressinput",
@@ -616,6 +619,15 @@ static_library("browser") {
}
}
+if (is_android) {
+ # GYP version: chrome/chrome_browser.gypi:chrome_browser_jni_headers
+ generate_jni("jni_headers") {
+ sources = rebase_path(
+ gypi_values.chrome_browser_jni_sources, ".", "//chrome")
+ jni_package = "chrome"
+ }
+}
+
# GYP version: chrome/chrome_resources.gyp:chrome_resources
# (generate_browser_resources action)
grit("resources") {
@@ -781,11 +793,16 @@ source_set("test_support") {
if (!is_ios) {
deps += [
"//components/sessions:test_support",
- "//extensions:test_support",
"//google_apis:test_support",
]
}
+ if (enable_extensions) {
+ deps += [
+ "//extensions:test_support",
+ ]
+ }
+
if (is_chromeos) {
sources += [
"chromeos/app_mode/fake_cws.cc",
« no previous file with comments | « chrome/BUILD.gn ('k') | chrome/browser/ui/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698