GN: Get //chrome/* mostly working on android

chrome/browser/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/crypto.gni")
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//components/nacl/nacl_defines.gni")
-import("//tools/grit/grit_rule.gni")
+# //build/config/android/rules.gni imports //tools/grit/grit_rule.gni, which
+# produces a conflict for the "grit" template so we have to only include one.

[jamesr, 2014/09/15 05:50:22]

this doesn't seem right, but it's needed to build. is this how imports are
expected to interact?

[cjhopman, 2014/09/15 17:23:07]

I had to do the same thing in //net. I definitely consider this a bug (I filed
http://crbug.com/393704 a while ago).

[brettw, 2014/09/15 18:11:10]

This is already fixed but I haven't pushed the new binary yet.

+if (is_android) {
+  import("//build/config/android/rules.gni")
+} else {
+  import("//tools/grit/grit_rule.gni")
+}
 
 about_credits_file = "$target_gen_dir/about_credits.html"
 additional_modules_list_file =
     "$root_gen_dir/chrome/browser/internal/additional_modules_list.txt"
 
 gypi_values = exec_script(
     "//build/gypi_to_gn.py",
     [ rebase_path("../chrome_browser.gypi") ],
     "scope",
     [ "../chrome_browser.gypi" ])
@@ skipping 41 matching lines @@
     "//components/invalidation",
     "//components/metrics:net",
     "//components/metrics/proto:proto",
     "//components/navigation_metrics",
     "//components/network_time",
     "//components/omaha_query_params",
     "//components/omnibox",
     "//components/os_crypt",
     "//components/password_manager/core/browser",
     "//components/password_manager/core/common",
-    "//components/pdf/browser",
     "//components/policy:policy_component",
     "//components/precache/core",
     "//components/query_parser",
     "//components/rappor",
     "//components/renderer_context_menu",
     "//components/search",
     "//components/search_engines",
     "//components/search_provider_logos",
     "//components/signin/core/browser",
     "//components/startup_metric_utils",
@@ skipping 173 matching lines @@
     deps += [ "//third_party/hunspell" ]
   }
   if (enable_nacl) {
     sources += rebase_path(gypi_values.chrome_browser_nacl_sources,
                            ".", "//chrome")
     #deps += [ "//components/nacl:nacl_browser" ]  TODO(GYP)
   }
   # ["debug_devtools==1", {  TODO(GYP)
   #   "defines": [
   #     "DEBUG_DEVTOOLS=1",
-  # ],
+  # }],
   if (enable_configuration_policy) {
     sources += rebase_path(
         gypi_values.chrome_browser_policy_shared_with_ios_sources,
         ".", "//chrome")
     deps += [
       "//components/policy",
       "//components/policy/proto",
     ]
     if (!is_ios) {
       sources += rebase_path(
           gypi_values.chrome_browser_policy_non_ios_sources,
           ".", "//chrome")
     }
     if (!is_chromeos) {
       sources += rebase_path(
           gypi_values.chrome_browser_policy_shared_with_ios_not_chromeos_sources,
           ".", "//chrome")
     }
     if (is_win || is_mac || is_desktop_linux) {
       sources += rebase_path(gypi_values.chrome_browser_policy_desktop_sources,
                              ".", "//chrome")
     }
-    if (is_android || is_ios) {
-      sources += rebase_path(gypi_values.chrome_browser_mobile_sources,
-                             ".", "//chrome")
-    } else {  # Non-mobile
+    if (!is_android && !is_ios) {  # Non-mobile
       deps += [
         "//chrome/browser/policy:path_parser",
       ]
     }
   } else {
     # Configuration policy disabled.
     sources += rebase_path(gypi_values.chrome_browser_policy_disabled_sources,
                            ".", "//chrome")
   }
 
   if (enable_plugins) {
     sources += rebase_path(gypi_values.chrome_browser_plugins_sources,
                            ".", "//chrome")
     deps += [
+      "//components/pdf/browser",
       "//ppapi:ppapi_ipc",
       "//third_party/adobe/flash:flapper_version_h",
     ]
   }
   if (safe_browsing_mode != 0) {
     sources += rebase_path(
         gypi_values.chrome_browser_basic_safe_browsing_sources,
         ".", "//chrome")
     deps += [
       "//chrome/browser/safe_browsing:chunk_proto",
@@ skipping 135 matching lines @@
     deps += [
       "//device/core",
       "//device/usb",
     ]
   }
 
   if (is_android) {
     sources += rebase_path(gypi_values.chrome_browser_android_sources,
                            ".", "//chrome")
     deps += [
+      ":jni_headers",
       "//components/cdm/browser",
       #"../components/components.gyp:web_contents_delegate_android",  TODO(GYP)
-      #"chrome_browser_jni_headers",  TODO(GYP)
     ]
     deps -= [
       "//third_party/libaddressinput",
       "//components/feedback",
       "//components/storage_monitor",
       "//components/web_modal",
     ]
   } else {
     sources += rebase_path(gypi_values.chrome_browser_non_android_sources,
                            ".", "//chrome")
@@ skipping 134 matching lines @@
     if (is_win || is_mac) {
       # TODO(brettw) as of this writing wifi bootstrapping is set on Windows
       # and Mac, so this test is meaningless. Can we merge these lists?
       sources += rebase_path(
           gypi_values.chrome_browser_win_mac_wifi_bootstrapping_sources,
           ".", "//chrome")
     }
   }
 }
 
+if (is_android) {
+  # GYP version: chrome/chrome_browser.gypi:chrome_browser_jni_headers
+  generate_jni("jni_headers") {
+    sources = rebase_path(
+        gypi_values.chrome_browser_jni_sources, ".", "//chrome")
+    jni_package = "chrome"
+  }
+}
+
 # GYP version: chrome/chrome_resources.gyp:chrome_resources
 # (generate_browser_resources action)
 grit("resources") {
   source = "browser_resources.grd"
   output_dir = "$root_gen_dir/chrome"
   outputs = [
     "grit/browser_resources.h",
     "browser_resources.pak",
   ]
 
@@ skipping 145 matching lines @@
   ]
 
   forward_dependent_configs_from = [
     ":browser",
     "//chrome/browser/ui:test_support",
   ]
 
   if (!is_ios) {
     deps += [
       "//components/sessions:test_support",
+      "//google_apis:test_support",
+    ]
+  }
+
+  if (enable_extensions) {
+    deps += [
       "//extensions:test_support",
-      "//google_apis:test_support",
     ]
   }
 
   if (is_chromeos) {
     sources += [
       "chromeos/app_mode/fake_cws.cc",
       "chromeos/app_mode/fake_cws.h",
       "chromeos/file_manager/fake_disk_mount_manager.cc",
       "chromeos/file_manager/fake_disk_mount_manager.h",
       "chromeos/input_method/mock_candidate_window_controller.cc",
@@ skipping 111 matching lines @@
     ]
   }
 
   if (enable_wifi_bootstrapping) {
     sources += [
       "local_discovery/wifi/mock_wifi_manager.cc",
       "local_discovery/wifi/mock_wifi_manager.h",
     ]
   }
 }