build/config/BUILD.gn - Issue 571863002: GN: Get //chrome/* mostly working on android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/BUILD.gn

Issue 571863002: GN: Get //chrome/* mostly working on android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/BUILD.gn

diff --git a/build/config/BUILD.gn b/build/config/BUILD.gn

index 7138336c296735658d8599d29db62b886882f77a..45b61cf024bb92d489b4f5a35b82365cfa5d8bb1 100644

--- a/build/config/BUILD.gn

+++ b/build/config/BUILD.gn

@@ -31,7 +31,6 @@ config("feature_flags") {

# TODO(brettw) most of these need to be parameterized.

defines = [

"CHROMIUM_BUILD",

- "ENABLE_NOTIFICATIONS",

"ENABLE_EGLIMAGE=1",

"ENABLE_BACKGROUND=1",

"V8_DEPRECATION_WARNINGS", # Don't use deprecated V8 APIs anywhere.

@@ -43,6 +42,9 @@ config("feature_flags") {

if (enable_mdns) {

defines += [ "ENABLE_MDNS=1" ]

}

+ if (enable_notifications) {

+ defines += [ "ENABLE_NOTIFICATIONS" ]

+ }

if (enable_pepper_cdms) {

# TODO(brettw) should probably be "=1"

defines += [ "ENABLE_PEPPER_CDMS" ]

« no previous file with comments | « BUILD.gn ('k') | chrome/BUILD.gn » ('j') | no next file with comments »