Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 571453002: Correct indentation, JSDoc, etc... to comply with closure linter. (Closed)

Created:
6 years, 3 months ago by fukino
Modified:
6 years, 3 months ago
Reviewers:
yoshiki, hirono
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Correct indentation, JSDoc, etc... to comply with closure linter. Errors reported by closure linter are fixed to keep accordance with style guide and prepare for closure compiler Some errors are ignored. - E:0007: We don't adopt the blank-line policy as it's not specified by style guide. - E:0011,0002,0225: There are some false positives around bind(). - E:0121: Comma at end of object literal is valid in ES5, and not prohibited by style guide. BUG=412662 TEST=find ui/file_manager -name *.js ! -path */*_scripts.js | xargs gjslint --strict --disable 0007,0011,0002,0121,0225 Committed: https://crrev.com/713ee20a4aa068ff1d9083d4fb115f77a6d2ff54 Cr-Commit-Position: refs/heads/master@{#295246}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Made it more strict. #

Total comments: 8

Patch Set 4 : Reflect review comments. #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+722 lines, -627 lines) Patch
M ui/file_manager/file_manager/audio_player/elements/track_list.js View 2 chunks +8 lines, -9 lines 0 comments Download
M ui/file_manager/file_manager/audio_player/js/audio_player.js View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/background/js/background.js View 1 2 3 2 chunks +14 lines, -14 lines 0 comments Download
M ui/file_manager/file_manager/background/js/drive_sync_handler.js View 2 chunks +6 lines, -6 lines 0 comments Download
M ui/file_manager/file_manager/background/js/file_operation_manager.js View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/file_manager/background/js/volume_manager.js View 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/file_manager/common/js/async_util.js View 1 chunk +3 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/common/js/util.js View 1 2 3 9 chunks +57 lines, -62 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/commandbutton.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/directory_contents.js View 2 chunks +2 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/directory_model.js View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/directory_tree.js View 6 chunks +10 lines, -6 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/drive_banners.js View 2 chunks +9 lines, -8 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_grid.js View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 2 3 4 10 chunks +51 lines, -53 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager_commands.js View 2 chunks +9 lines, -10 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_selection.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_table.js View 2 chunks +9 lines, -9 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_tasks.js View 4 chunks +16 lines, -16 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_transfer_controller.js View 1 2 3 4 8 chunks +22 lines, -25 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_type.js View 3 chunks +160 lines, -80 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_watcher.js View 2 chunks +13 lines, -13 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/byte_reader.js View 5 chunks +6 lines, -8 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/function_sequence.js View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/id3_parser.js View 5 chunks +18 lines, -21 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/image_parsers.js View 4 chunks +14 lines, -13 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js View 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/metadata_dispatcher.js View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/navigation_list_model.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/share_dialog.js View 2 chunks +6 lines, -6 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/suggest_apps_dialog.js View 1 chunk +15 lines, -15 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/thumbnail_loader.js View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/breadcrumbs_controller.js View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/multi_profile_share_dialog.js View 2 chunks +24 lines, -25 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/search_box.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/volume_manager_wrapper.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/gallery/js/background.js View 1 2 2 chunks +8 lines, -7 lines 0 comments Download
M ui/file_manager/gallery/js/gallery.js View 4 chunks +5 lines, -2 lines 0 comments Download
M ui/file_manager/gallery/js/gallery_item.js View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/file_manager/gallery/js/image_editor/exif_encoder.js View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M ui/file_manager/gallery/js/image_editor/filter.js View 1 2 3 chunks +12 lines, -12 lines 0 comments Download
M ui/file_manager/gallery/js/image_editor/image_adjust.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/gallery/js/image_editor/image_editor.js View 1 2 4 chunks +17 lines, -16 lines 0 comments Download
M ui/file_manager/gallery/js/image_editor/image_encoder.js View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ui/file_manager/gallery/js/image_editor/image_transform.js View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/file_manager/gallery/js/image_editor/image_util.js View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M ui/file_manager/gallery/js/image_editor/image_view.js View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M ui/file_manager/gallery/js/image_editor/viewport.js View 5 chunks +10 lines, -1 line 0 comments Download
M ui/file_manager/gallery/js/mosaic_mode.js View 1 2 3 chunks +6 lines, -5 lines 0 comments Download
M ui/file_manager/gallery/js/slide_mode.js View 1 2 3 6 chunks +20 lines, -18 lines 0 comments Download
M ui/file_manager/image_loader/cache.js View 1 2 2 chunks +14 lines, -13 lines 0 comments Download
M ui/file_manager/image_loader/image_loader.js View 1 2 2 chunks +23 lines, -26 lines 0 comments Download
M ui/file_manager/image_loader/image_loader_client.js View 1 2 3 chunks +15 lines, -12 lines 0 comments Download
M ui/file_manager/image_loader/request.js View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M ui/file_manager/video_player/js/background.js View 2 chunks +2 lines, -1 line 0 comments Download
M ui/file_manager/video_player/js/cast/cast_extension_discoverer.js View 1 2 1 chunk +7 lines, -8 lines 0 comments Download
M ui/file_manager/video_player/js/cast/cast_video_element.js View 1 2 3 2 chunks +12 lines, -12 lines 0 comments Download
M ui/file_manager/video_player/js/cast/caster.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/video_player/js/media_controls.js View 1 2 2 chunks +10 lines, -10 lines 0 comments Download
M ui/file_manager/video_player/js/video_player.js View 1 2 3 4 6 chunks +34 lines, -32 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
fukino
@yoshiki - PTAL at video_player and file_manager. @hirono - PTAL at gallery and image_loader. Thanks!
6 years, 3 months ago (2014-09-12 14:59:03 UTC) #2
yoshiki
lgtm with nits. Thank you for doing hard work. https://codereview.chromium.org/571453002/diff/40001/ui/file_manager/file_manager/background/js/background.js File ui/file_manager/file_manager/background/js/background.js (right): https://codereview.chromium.org/571453002/diff/40001/ui/file_manager/file_manager/background/js/background.js#newcode301 ui/file_manager/file_manager/background/js/background.js:301: ...
6 years, 3 months ago (2014-09-16 00:49:09 UTC) #3
hirono
On 2014/09/16 00:49:09, yoshiki wrote: > lgtm with nits. Thank you for doing hard work. ...
6 years, 3 months ago (2014-09-16 01:06:16 UTC) #4
fukino
Thank you for the review and comments! https://codereview.chromium.org/571453002/diff/40001/ui/file_manager/file_manager/background/js/background.js File ui/file_manager/file_manager/background/js/background.js (right): https://codereview.chromium.org/571453002/diff/40001/ui/file_manager/file_manager/background/js/background.js#newcode301 ui/file_manager/file_manager/background/js/background.js:301: profileId, function() ...
6 years, 3 months ago (2014-09-17 05:17:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571453002/60001
6 years, 3 months ago (2014-09-17 05:18:24 UTC) #7
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-17 07:19:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571453002/60001
6 years, 3 months ago (2014-09-17 07:40:01 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/16251)
6 years, 3 months ago (2014-09-17 07:49:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571453002/80001
6 years, 3 months ago (2014-09-17 07:55:58 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:80001) as c71c3e32fdeb1defc45b7239242845379d6fe8ba
6 years, 3 months ago (2014-09-17 08:53:28 UTC) #16
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 08:54:12 UTC) #17
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/713ee20a4aa068ff1d9083d4fb115f77a6d2ff54
Cr-Commit-Position: refs/heads/master@{#295246}

Powered by Google App Engine
This is Rietveld 408576698