Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Unified Diff: ui/file_manager/file_manager/foreground/js/thumbnail_loader.js

Issue 571453002: Correct indentation, JSDoc, etc... to comply with closure linter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/thumbnail_loader.js
diff --git a/ui/file_manager/file_manager/foreground/js/thumbnail_loader.js b/ui/file_manager/file_manager/foreground/js/thumbnail_loader.js
index 3cb5491b4096803277830fdb9ccf4cb2a0695d8f..3077c0eaf015ac193397fd14a0b151747c3342b6 100644
--- a/ui/file_manager/file_manager/foreground/js/thumbnail_loader.js
+++ b/ui/file_manager/file_manager/foreground/js/thumbnail_loader.js
@@ -134,10 +134,10 @@ ThumbnailLoader.THUMBNAIL_MAX_HEIGHT = 500;
* @param {ThumbnailLoader.FillMode} fillMode Fill mode.
* @param {ThumbnailLoader.OptimizationMode=} opt_optimizationMode Optimization
* for downloading thumbnails. By default optimizations are disabled.
- * @param {function(Image, Object)} opt_onSuccess Success callback,
+ * @param {function(Image, Object)=} opt_onSuccess Success callback,
* accepts the image and the transform.
- * @param {function} opt_onError Error callback.
- * @param {function} opt_onGeneric Callback for generic image used.
+ * @param {function=} opt_onError Error callback.
+ * @param {function=} opt_onGeneric Callback for generic image used.
*/
ThumbnailLoader.prototype.load = function(box, fillMode, opt_optimizationMode,
opt_onSuccess, opt_onError, opt_onGeneric) {
@@ -391,7 +391,7 @@ ThumbnailLoader.centerImage_ = function(box, img, fillMode, rotate) {
Math.min(fitScaleX, fitScaleY);
if (fillMode !== ThumbnailLoader.FillMode.OVER_FILL)
- scale = Math.min(scale, 1); // Never overscale.
+ scale = Math.min(scale, 1); // Never overscale.
fractionX = imageWidth * scale / boxWidth;
fractionY = imageHeight * scale / boxHeight;

Powered by Google App Engine
This is Rietveld 408576698