Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: ui/file_manager/file_manager/foreground/js/metadata/byte_reader.js

Issue 571453002: Correct indentation, JSDoc, etc... to comply with closure linter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/metadata/byte_reader.js
diff --git a/ui/file_manager/file_manager/foreground/js/metadata/byte_reader.js b/ui/file_manager/file_manager/foreground/js/metadata/byte_reader.js
index 30f2d011f1ea7338473f79545d48a9f7aa787f9f..e3fbfb210e9c875f7f49617db0a5c51fb1f6b952 100644
--- a/ui/file_manager/file_manager/foreground/js/metadata/byte_reader.js
+++ b/ui/file_manager/file_manager/foreground/js/metadata/byte_reader.js
@@ -126,8 +126,8 @@ ByteReader.readNullTerminatedString = function(dataView, pos, size, opt_end) {
* same name which side-effects the current read position.
*
* @param {DataView} dataView Data view instance.
- * @param {boolean} bom True if BOM should be parsed.
* @param {number} pos Position in bytes to read from.
+ * @param {boolean} bom True if BOM should be parsed.
* @param {number} size Number of bytes to read.
* @param {number=} opt_end Maximum position to read from.
* @return {string} Read string.
@@ -233,10 +233,10 @@ ByteReader.readImage = function(dataView, pos, size, opt_end) {
// Two bytes is enough to identify the mime type.
var prefixToMime = {
- '\x89P' : 'png',
- '\xFF\xD8' : 'jpeg',
- 'BM' : 'bmp',
- 'GI' : 'gif'
+ '\x89P' : 'png',
+ '\xFF\xD8' : 'jpeg',
+ 'BM' : 'bmp',
+ 'GI' : 'gif'
};
var prefix = ByteReader.readString(dataView, pos, 2, opt_end);
@@ -256,7 +256,7 @@ ByteReader.readImage = function(dataView, pos, size, opt_end) {
* @return {boolean} True if allowed, false otherwise.
*/
ByteReader.prototype.canRead = function(size) {
- return this.pos_ + size <= this.view_.byteLength;
+ return this.pos_ + size <= this.view_.byteLength;
};
/**
@@ -396,7 +396,6 @@ ByteReader.prototype.readNullTerminatedString = function(size, opt_end) {
* read would go past the end of the buffer.
*
* @param {boolean} bom True if BOM should be parsed.
- * @param {number} pos Position in bytes to read from.
* @param {number} size Number of bytes to read.
* @param {number=} opt_end Maximum position to read from.
* @return {string} Read string.
@@ -469,7 +468,6 @@ ByteReader.prototype.readBase64 = function(size, opt_end) {
* Adjusts the current position on success. Throws an exception if the
* read would go past the end of the buffer.
*
- * @param {number} pos Position in bytes to read from.
* @param {number} size Number of bytes to read.
* @param {number=} opt_end Maximum position to read from.
* @return {string} Image as a data url.

Powered by Google App Engine
This is Rietveld 408576698