Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: ui/file_manager/file_manager/foreground/js/directory_tree.js

Issue 571453002: Correct indentation, JSDoc, etc... to comply with closure linter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/directory_tree.js
diff --git a/ui/file_manager/file_manager/foreground/js/directory_tree.js b/ui/file_manager/file_manager/foreground/js/directory_tree.js
index 7b447dfe52d88d972c4e55d70a869a35ba56484f..e7295885e4df0f2b11ed805d8b2cb31951437985 100644
--- a/ui/file_manager/file_manager/foreground/js/directory_tree.js
+++ b/ui/file_manager/file_manager/foreground/js/directory_tree.js
@@ -393,6 +393,9 @@ DirectoryItem.prototype.setContextMenu = function(menu) {
cr.ui.contextMenuHandler.setContextMenu(this, menu);
};
+/**
+ * Change current directory to the entry of this item.
+ */
DirectoryItem.prototype.activate = function() {
this.parentTree_.directoryModel.activateDirectoryEntry(this.entry);
};
@@ -404,7 +407,7 @@ DirectoryItem.prototype.activate = function() {
* A TreeItem which represents a volume. Volume items are displayed as
* top-level children of DirectoryTree.
*
- * @param {DirectoryEntry} dirEntry DirectoryEntry of this item.
+ * @param {DirectoryEntry} entry DirectoryEntry of this item.
* @param {NavigationModelItem} modelItem NavigationModelItem of this volume.
* @param {DirectoryTree} tree Current tree, which contains this item.
* @extends {cr.ui.TreeItem}
@@ -457,7 +460,7 @@ VolumeItem.prototype.searchAndSelectByEntry = function(entry) {
/**
* Decorates this element.
- * @param {DirectoryEntry} dirEntry DirectoryEntry of this item.
+ * @param {DirectoryEntry} entry DirectoryEntry of this item.
* @param {NavigationModelItem} modelItem NavigationModelItem of this volume.
* @param {DirectoryTree} tree Current tree, which contains this item.
*/
@@ -581,7 +584,7 @@ VolumeItem.prototype.activate = function() {
function() {
// Error, the display root is not available. It may happen on Drive.
this.parentTree_.dataModel.onItemNotFoundError(this.modelItem);
- }.bind(this))
+ }.bind(this));
};
/**
@@ -1024,6 +1027,7 @@ DirectoryTree.prototype.selectByEntry = function(entry) {
/**
* Select the volume or the shortcut corresponding to the given index.
* @param {number} index 0-based index of the target top-level item.
+ * @return {boolean} True if one of the volume items is selected.
*/
DirectoryTree.prototype.selectByIndex = function(index) {
if (index < 0 || index >= this.items.length)
@@ -1057,9 +1061,9 @@ DirectoryTree.prototype.updateSubDirectories = function(
}.bind(this)));
} else {
// Shortcuts' root entries can be obtained immediately.
- itemPromises.push(
- Promise.resolve({entry: this.dataModel.item(i).entry,
- modelItem: this.dataModel.item(i)}));
+ itemPromises.push(Promise.resolve({
+ entry: this.dataModel.item(i).entry,
+ modelItem: this.dataModel.item(i)}));
}
}

Powered by Google App Engine
This is Rietveld 408576698