Make content_shell_apk build completely

Make content_shell_apk build completely

This fixes configuration of various targets (mostly adding some missing
files for is_android builds).

Adds a target setting up the content_shell_apk assets directory.

Uncomments the previously non-working dependencies from
libcontent_shell_content_view.

Adds forwarding of testonly in all of the android templates.

TBR=mark@

BUG=359249
Committed: https://crrev.com/2fd48fd14b188a0b854f9c5910b9f40b5576291f
Cr-Commit-Position: refs/heads/master@{#296319}

[cjhopman, 2014-09-15 02:09:55]

Patchset #1 (id:1) has been deleted

[cjhopman, 2014-09-15 02:14:15]

Patchset #1 (id:20001) has been deleted

[cjhopman, 2014-09-15 02:14:21]

Patchset #1 (id:40001) has been deleted

[cjhopman, 2014-09-15 02:14:34]

cjhopman@chromium.org changed reviewers:
+ jamesr@chromium.org

[cjhopman, 2014-09-15 02:14:34]

jamesr: *

[jamesr, 2014-09-15 04:03:07]

lgtm

https://codereview.chromium.org/569923003/diff/60001/build/config/android/int...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/569923003/diff/60001/build/config/android/int...
build/config/android/internal_rules.gni:18: if (defined(invoker.testonly)) {
testonly = invoker.testonly }
this style seems less common in GN templates outside of BUILDCONFIG.gn.  I think
it's fine, personally, but it's a little odd how inconsistent we are

https://codereview.chromium.org/569923003/diff/60001/content/shell/android/BU...
File content/shell/android/BUILD.gn (right):

https://codereview.chromium.org/569923003/diff/60001/content/shell/android/BU...
content/shell/android/BUILD.gn:82: content_shell_assets_dir =
"$root_build_dir/content_shell/assets"
can you declare this inside the target or is it reused? does it need to be a var
at all?

[cjhopman, 2014-09-17 23:06:34]

cjhopman@chromium.org changed reviewers:
+ brettw@chromium.org

[cjhopman, 2014-09-17 23:06:35]

brettw for OWNERS of most things

[cjhopman, 2014-09-18 01:00:35]

https://codereview.chromium.org/569923003/diff/60001/content/shell/android/BU...
File content/shell/android/BUILD.gn (right):

https://codereview.chromium.org/569923003/diff/60001/content/shell/android/BU...
content/shell/android/BUILD.gn:82: content_shell_assets_dir =
"$root_build_dir/content_shell/assets"
On 2014/09/15 04:03:07, jamesr wrote:
> can you declare this inside the target or is it reused? does it need to be a
var
> at all?
Done. It is now reused.

[jamesr, 2014-09-18 01:01:57]

Gotcha, makes sense.

[brettw, 2014-09-20 05:47:36]

lgtm

https://codereview.chromium.org/569923003/diff/80001/build/config/BUILD.gn
File build/config/BUILD.gn (right):

https://codereview.chromium.org/569923003/diff/80001/build/config/BUILD.gn#ne...
build/config/BUILD.gn:49: if (enable_notifications) {
Isn't this the thing you added above?

[cjhopman, 2014-09-22 18:43:52]

cjhopman@chromium.org changed reviewers:
+ jam@chromium.org, mark@chromium.org, sky@chromium.org

[cjhopman, 2014-09-22 18:43:53]

And adding some more OWNERS

jam: content/
mark: breakpad/
sky: ui/

https://codereview.chromium.org/569923003/diff/80001/build/config/BUILD.gn
File build/config/BUILD.gn (right):

https://codereview.chromium.org/569923003/diff/80001/build/config/BUILD.gn#ne...
build/config/BUILD.gn:49: if (enable_notifications) {
On 2014/09/20 05:47:36, brettw (no non-GN reviews plz) wrote:
> Isn't this the thing you added above?

Yep, looks like jamesr landed that bit before me.

[sky, 2014-09-22 20:45:38]

I'm not a good owner for ui/android. Is there a more local owner that can review
it for you?

[cjhopman, 2014-09-22 20:46:48]

cjhopman@chromium.org changed reviewers:
+ tedchoc@chromium.org

[cjhopman, 2014-09-22 20:46:48]

sure. tedchoc@ for ui/android

[Ted C, 2014-09-22 20:53:29]

ui/android - lgtm

[jam, 2014-09-23 05:10:32]

rubberstamp lgtm based on brettw's reviews

[cjhopman, 2014-09-24 00:48:12]

The CQ bit was checked by cjhopman@chromium.org

[commit-bot: I haz the power, 2014-09-24 00:48:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/569923003/100001

[commit-bot: I haz the power, 2014-09-24 00:53:03]

Committed patchset #3 (id:100001) as ba37f90bf1d62a975893de87cf221983dc5c21c1

[commit-bot: I haz the power, 2014-09-24 00:53:44]

Patchset 3 (id:??) landed as
https://crrev.com/2fd48fd14b188a0b854f9c5910b9f40b5576291f
Cr-Commit-Position: refs/heads/master@{#296319}