Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1621)

Side by Side Diff: build/secondary/third_party/icu/BUILD.gn

Issue 569923003: Make content_shell_apk build completely (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-fix-apk-resources
Patch Set: Rebase + remove redundant notifications define Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/config/android/rules.gni ('k') | build/secondary/third_party/icu/config.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 declare_args() { 5 import("//third_party/icu/config.gni")
6 # Tells icu to load an external data file rather than rely on the icudata
7 # being linked directly into the binary.
8 #
9 # This flag is a bit confusing. As of this writing, icu.gyp set the value to
10 # 0 but common.gypi sets the value to 1 for most platforms (and the 1 takes
11 # precedence).
12 #
13 # TODO(GYP) We'll probably need to enhance this logic to set the value to
14 # true or false in similar circumstances. Note that in the GYP build, some
15 # other projects access this variable. If we need to do a similar thing,
16 # we should probably make an icu config file (//third_party/icu/config.gni)
17 # with this flag in it rather than making it global.
18 icu_use_data_file = true
19 }
20 6
21 # Meta target that includes both icuuc and icui18n. Most targets want both. 7 # Meta target that includes both icuuc and icui18n. Most targets want both.
22 # You can depend on the individually if you need to. 8 # You can depend on the individually if you need to.
23 group("icu") { 9 group("icu") {
24 deps = [ 10 deps = [
25 ":icui18n", 11 ":icui18n",
26 ":icuuc", 12 ":icuuc",
27 ] 13 ]
28 } 14 }
29 15
(...skipping 486 matching lines...) Expand 10 before | Expand all | Expand 10 after
516 sources = [ "mac/icudtl_dat.S" ] 502 sources = [ "mac/icudtl_dat.S" ]
517 } else if (is_android) { 503 } else if (is_android) {
518 sources = [ "android/icudtl_dat.S" ] 504 sources = [ "android/icudtl_dat.S" ]
519 } else { 505 } else {
520 assert(false, "No icu data for this platform") 506 assert(false, "No icu data for this platform")
521 } 507 }
522 defines = [ "U_HIDE_DATA_SYMBOL" ] 508 defines = [ "U_HIDE_DATA_SYMBOL" ]
523 } 509 }
524 } 510 }
525 } 511 }
OLDNEW
« no previous file with comments | « build/config/android/rules.gni ('k') | build/secondary/third_party/icu/config.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698