Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3097)

Unified Diff: build/secondary/third_party/icu/BUILD.gn

Issue 569923003: Make content_shell_apk build completely (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-fix-apk-resources
Patch Set: Rebase + remove redundant notifications define Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/android/rules.gni ('k') | build/secondary/third_party/icu/config.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/secondary/third_party/icu/BUILD.gn
diff --git a/build/secondary/third_party/icu/BUILD.gn b/build/secondary/third_party/icu/BUILD.gn
index 1a219491e8a6ba00e82a8c9e5ebdf98794bd3c56..4f5858cf41c766fd7877d396c26d41a06e9a3053 100644
--- a/build/secondary/third_party/icu/BUILD.gn
+++ b/build/secondary/third_party/icu/BUILD.gn
@@ -2,21 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-declare_args() {
- # Tells icu to load an external data file rather than rely on the icudata
- # being linked directly into the binary.
- #
- # This flag is a bit confusing. As of this writing, icu.gyp set the value to
- # 0 but common.gypi sets the value to 1 for most platforms (and the 1 takes
- # precedence).
- #
- # TODO(GYP) We'll probably need to enhance this logic to set the value to
- # true or false in similar circumstances. Note that in the GYP build, some
- # other projects access this variable. If we need to do a similar thing,
- # we should probably make an icu config file (//third_party/icu/config.gni)
- # with this flag in it rather than making it global.
- icu_use_data_file = true
-}
+import("//third_party/icu/config.gni")
# Meta target that includes both icuuc and icui18n. Most targets want both.
# You can depend on the individually if you need to.
« no previous file with comments | « build/config/android/rules.gni ('k') | build/secondary/third_party/icu/config.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698