content/shell/BUILD.gn - Issue 569923003: Make content_shell_apk build completely

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/BUILD.gn

Issue 569923003: Make content_shell_apk build completely (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-fix-apk-resources

Patch Set: Rebase + remove redundant notifications define Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/shell/BUILD.gn

diff --git a/content/shell/BUILD.gn b/content/shell/BUILD.gn

index 6d52357aab6978fe1d50200c6a97f9e96aeedfba..6a360f786a00daf0102723dca49256c63b4e2a4b 100644

--- a/content/shell/BUILD.gn

+++ b/content/shell/BUILD.gn

@@ -432,13 +432,9 @@ repack("pak") {

"//ui/strings",

]

- if (is_android) {

- output = "$root_out_dir/content_shell/assets/content_shell.pak"

- } else {

- sources += [ "$root_gen_dir/webkit/devtools_resources.pak" ]

- deps += [ "//content/browser/devtools:resources" ]

- output = "$root_out_dir/content_shell.pak"

- }

+ sources += [ "$root_gen_dir/webkit/devtools_resources.pak" ]

+ deps += [ "//content/browser/devtools:resources" ]

+ output = "$root_out_dir/content_shell.pak"

}

# TODO(GYP): Figure out what this should be on android

« no previous file with comments | « content/renderer/BUILD.gn ('k') | content/shell/android/BUILD.gn » ('j') | no next file with comments »