Fix for Insertion Handle disappearing

Fix for Insertion Handle disappearing

In RWHVA::SelectionBoundsChanged, there is a check
for anchor_rect x and y not being 0. Due to this, whenever
the cursor reaches 0 position (either left or top), it
triggers HideAndDisallowShowAutomatically.
This causes the insertion handle not to be shown on
scroll end. Restricting this condition to only check for
the origin minimizes the likelihood of the issue.

BUG=414020
Committed: https://crrev.com/057d93c5bc7798ea1343ed6698166bfb5d359344
Cr-Commit-Position: refs/heads/master@{#295009}

[AviD, 2014-09-13 11:43:00]

avi.nitk@samsung.com changed reviewers:
+ jdduke@chromium.org

[AviD, 2014-09-13 11:43:01]

@jdduke:
Is there any particular reason for having this check?

If yes, then can we work on a way of solving that issue and the issue 414020?

[jdduke (slow), 2014-09-15 15:02:13]

On 2014/09/13 11:43:01, AviD wrote:
> @jdduke:
> Is there any particular reason for having this check?

Yes, otherwise there's not currently a way of distinguishing between a "cleared"
selection and a valid insertion.

> 
> If yes, then can we work on a way of solving that issue and the issue 414020?

We already have, it will be fixed as soon as
https://codereview.chromium.org/359033002/ lands.

[jdduke (slow), 2014-09-15 15:37:13]

https://codereview.chromium.org/569003002/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/render_widget_host_view_android.cc (left):

https://codereview.chromium.org/569003002/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/render_widget_host_view_android.cc:832: if
(params.anchor_rect.x() && params.anchor_rect.y())
Actually, we could probably change this to

if (params.anchor_rect.x() || params.anchor_rect.y())

If you'd like to make that change, that would be fine.

[AviD, 2014-09-15 16:22:19]

@jdduke Could you please take a look?

https://codereview.chromium.org/569003002/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/render_widget_host_view_android.cc (left):

https://codereview.chromium.org/569003002/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/render_widget_host_view_android.cc:832: if
(params.anchor_rect.x() && params.anchor_rect.y())
On 2014/09/15 15:37:13, jdduke wrote:
> Actually, we could probably change this to
> 
> if (params.anchor_rect.x() || params.anchor_rect.y())
> 
> If you'd like to make that change, that would be fine.

Yes, this will reduce the frequency of the issue. But if you place the anchor
rect at the (0,0) position, the issue can be reproduced again. However, its
still better than the handle disappearing every time the cursor is moved to the
left-edge or top of screen.

I have made the change accordingly.

[jdduke (slow), 2014-09-15 16:34:06]

jdduke@chromium.org changed reviewers:
+ aelias@chromium.org

[jdduke (slow), 2014-09-15 16:34:07]

On 2014/09/15 16:22:19, AviD wrote:
> Yes, this will reduce the frequency of the issue. But if you place the anchor
> rect at the (0,0) position, the issue can be reproduced again. However, its
> still better than the handle disappearing every time the cursor is moved to
the
> left-edge or top of screen.
> 

Right. As I said, this code will soon be removed completely, but this small fix
can't hurt in case the eventual fix gets pushed back for some reason.

> I have made the change accordingly.

Thanks, lgtm. Adding aelias@ for owner review.

[aelias_OOO_until_Jul13, 2014-09-15 17:56:03]

lgtm

[AviD, 2014-09-16 03:37:34]

The CQ bit was checked by avi.nitk@samsung.com

[commit-bot: I haz the power, 2014-09-16 03:41:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/569003002/20001

[commit-bot: I haz the power, 2014-09-16 04:49:59]

Committed patchset #2 (id:20001) as baf04e93e28e31d56034665721c00805512a9f05

[commit-bot: I haz the power, 2014-09-16 04:52:53]

Patchset 2 (id:??) landed as
https://crrev.com/057d93c5bc7798ea1343ed6698166bfb5d359344
Cr-Commit-Position: refs/heads/master@{#295009}