Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 359033002: [Android] Enable composited selection updates (Closed)

Created:
6 years, 5 months ago by jdduke (slow)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, miu+watch_chromium.org, nasko+codewatch_chromium.org, nona+watch_chromium.org, penghuang+watch_chromium.org, James Su, yukishiino+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@input_native_handles_0_compositor
Project:
chromium
Visibility:
Public.

Description

[Android] Enable composited selection updates Now that selection bounds are routed through the compositor, enable the feature in Blink and hook the CompositorFrameMetadata-carried bounds into the existing selection handle pipeline. Also suppress the sending of ViewHostMsg_SelectionBoundsChanged messages when the feature is enabled. This patch depends directly on https://codereview.chromium.org/454643002/. BUG=135959 Committed: https://crrev.com/acf809ece9c1326d7fc4655b505146f55b3d04a1 Cr-Commit-Position: refs/heads/master@{#296218}

Patch Set 1 #

Patch Set 2 : Updates #

Patch Set 3 : Rebase #

Patch Set 4 : More updates #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase to https://codereview.chromium.org/494823002/ #

Patch Set 7 : Rebase #

Patch Set 8 : Rebase #

Patch Set 9 : Rebase #

Total comments: 2

Patch Set 10 : Use WebRuntimeFeatures query and hide/show on blur/focus #

Patch Set 11 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -85 lines) Patch
M content/browser/renderer_host/render_widget_host_view_android.h View 1 2 3 4 5 6 7 8 9 2 chunks +0 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 2 3 4 5 6 7 8 9 9 chunks +9 lines, -69 lines 0 comments Download
M content/child/runtime_features.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +16 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
jdduke (slow)
PTAL, thanks. aelias@: content/browser/renderer_host jochen@: content/child, content/renderer
6 years, 3 months ago (2014-09-19 00:21:41 UTC) #2
jochen (gone - plz use gerrit)
https://codereview.chromium.org/359033002/diff/150001/content/renderer/render_widget.cc File content/renderer/render_widget.cc (right): https://codereview.chromium.org/359033002/diff/150001/content/renderer/render_widget.cc#newcode1826 content/renderer/render_widget.cc:1826: #if !defined(OS_ANDROID) why not add WebRuntimeFeatures::isCompositedSelectionUpdatesEnabled() and skip this ...
6 years, 3 months ago (2014-09-19 13:25:10 UTC) #3
jochen (gone - plz use gerrit)
https://codereview.chromium.org/359033002/diff/150001/content/renderer/render_widget.cc File content/renderer/render_widget.cc (right): https://codereview.chromium.org/359033002/diff/150001/content/renderer/render_widget.cc#newcode1826 content/renderer/render_widget.cc:1826: #if !defined(OS_ANDROID) why not add WebRuntimeFeatures::isCompositedSelectionUpdatesEnabled() and skip this ...
6 years, 3 months ago (2014-09-19 13:25:11 UTC) #4
jdduke (slow)
https://codereview.chromium.org/359033002/diff/150001/content/renderer/render_widget.cc File content/renderer/render_widget.cc (right): https://codereview.chromium.org/359033002/diff/150001/content/renderer/render_widget.cc#newcode1826 content/renderer/render_widget.cc:1826: #if !defined(OS_ANDROID) On 2014/09/19 13:25:11, jochen (slow for reviews) ...
6 years, 3 months ago (2014-09-19 15:46:07 UTC) #5
aelias_OOO_until_Jul13
renderer_host lgtm
6 years, 3 months ago (2014-09-19 19:36:36 UTC) #6
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-22 09:49:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/359033002/190001
6 years, 3 months ago (2014-09-23 15:47:16 UTC) #9
commit-bot: I haz the power
Committed patchset #11 (id:190001) as 4c5238b46d7debea8fe0d0b9cfa4ddd7d459dae1
6 years, 3 months ago (2014-09-23 20:38:46 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 20:39:28 UTC) #11
Message was sent while issue was closed. 
Patchset 11 (id:??) landed as
https://crrev.com/acf809ece9c1326d7fc4655b505146f55b3d04a1
Cr-Commit-Position: refs/heads/master@{#296218}

Powered by Google App Engine
This is Rietveld 408576698