content/browser/renderer_host/render_widget_host_view_android.cc - Issue 569003002: Fix for Insertion Handle disappearing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 569003002: Fix for Insertion Handle disappearing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: changed according to review comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_view_android.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc

index 9ccfa6ccc0491fcc4fae669b07b4fc8aa996463a..48070031aa230d87a4f199e77145ee5cc5b1aee1 100644

--- a/content/browser/renderer_host/render_widget_host_view_android.cc

+++ b/content/browser/renderer_host/render_widget_host_view_android.cc

@@ -829,7 +829,7 @@ void RenderWidgetHostViewAndroid::SelectionBoundsChanged(

end_bound.edge_bottom = end_rect.bottom_left();

if (params.anchor_rect == params.focus_rect) {

- if (params.anchor_rect.x() && params.anchor_rect.y())

+ if (params.anchor_rect.x() || params.anchor_rect.y())

start_bound.type = end_bound.type = cc::SELECTION_BOUND_CENTER;

} else {

start_bound.type = params.anchor_dir == blink::WebTextDirectionRightToLeft

« no previous file with comments | « no previous file | no next file » | no next file with comments »