Fix for Insertion Handle disappearing

content/browser/renderer_host/render_widget_host_view_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_android.h"
 
 #include <android/bitmap.h>
 
 #include "base/android/build_info.h"
 #include "base/basictypes.h"
@@ skipping 811 matching lines @@
 
   cc::ViewportSelectionBound start_bound, end_bound;
   start_bound.visible = true;
   end_bound.visible = true;
   start_bound.edge_top = start_rect.origin();
   start_bound.edge_bottom = start_rect.bottom_left();
   end_bound.edge_top = end_rect.origin();
   end_bound.edge_bottom = end_rect.bottom_left();
 
   if (params.anchor_rect == params.focus_rect) {
-    if (params.anchor_rect.x() && params.anchor_rect.y())

[jdduke (slow), 2014/09/15 15:37:13]

Actually, we could probably change this to

if (params.anchor_rect.x() || params.anchor_rect.y())

If you'd like to make that change, that would be fine.

[AviD, 2014/09/15 16:22:19]

Yes, this will reduce the frequency of the issue. But if you place the anchor
rect at the (0,0) position, the issue can be reproduced again. However, its
still better than the handle disappearing every time the cursor is moved to the
left-edge or top of screen.

I have made the change accordingly.

-      start_bound.type = end_bound.type = cc::SELECTION_BOUND_CENTER;
+    start_bound.type = end_bound.type = cc::SELECTION_BOUND_CENTER;
   } else {
     start_bound.type = params.anchor_dir == blink::WebTextDirectionRightToLeft
                            ? cc::SELECTION_BOUND_LEFT
                            : cc::SELECTION_BOUND_RIGHT;
     end_bound.type = params.focus_dir == blink::WebTextDirectionRightToLeft
                          ? cc::SELECTION_BOUND_RIGHT
                          : cc::SELECTION_BOUND_LEFT;
   }
 
   selection_controller_->OnSelectionBoundsChanged(start_bound, end_bound);
@@ skipping 1023 matching lines @@
   results->orientationAngle = display.RotationAsDegree();
   results->orientationType =
       RenderWidgetHostViewBase::GetOrientationTypeForMobile(display);
   gfx::DeviceDisplayInfo info;
   results->depth = info.GetBitsPerPixel();
   results->depthPerComponent = info.GetBitsPerComponent();
   results->isMonochrome = (results->depthPerComponent == 0);
 }
 
 } // namespace content