Refactoring the weak_ptr_factory order content/browser folder

Refactoring the weak_ptr_factory order content/browser folder

Changing in the intialization order of WeakPtrFactory such that all
member variables should appear before the WeakPtrFactory to ensure
that any WeakPtrs to Controller are invalidated before its members
variable's destructors are executed, rendering them invalid.

BUG=303818
Committed: https://crrev.com/371ad91448d53434c2de797eb875c332d4b0a001
Cr-Commit-Position: refs/heads/master@{#295238}

[MRV, 2014-09-12 07:48:59]

mohan.reddy@samsung.com changed reviewers:
+ avi@chromium.org

[MRV, 2014-09-12 07:49:00]

PTAL

[Avi (use Gerrit), 2014-09-12 15:33:33]

lgtm

BTW why are you removing the email addresses in the CC line? Please don't do
that. If you want to ADD an email, OK. Don't REMOVE any, though.

[MRV, 2014-09-12 18:10:51]

The CQ bit was checked by mohan.reddy@samsung.com

[MRV, 2014-09-12 18:12:00]

On 2014/09/12 15:33:33, Avi wrote:
> lgtm
> 
> BTW why are you removing the email addresses in the CC line? Please don't do
> that. If you want to ADD an email, OK. Don't REMOVE any, though.

Dear mr.Avi.. thanks for lgtm.
I will follow your suggestions for sure from next reviews.

[commit-bot: I haz the power, 2014-09-12 18:19:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/567943002/1

[commit-bot: I haz the power, 2014-09-12 19:44:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-12 19:44:32]

Try jobs failed on following builders:
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)
  mac_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered...)
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[MRV, 2014-09-13 09:04:38]

The CQ bit was checked by mohan.reddy@samsung.com

[commit-bot: I haz the power, 2014-09-13 09:04:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/567943002/1

[commit-bot: I haz the power, 2014-09-13 09:07:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-13 09:07:32]

Try jobs failed on following builders:
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)
  mac_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered...)

[MRV, 2014-09-15 04:45:31]

The CQ bit was checked by mohan.reddy@samsung.com

[commit-bot: I haz the power, 2014-09-15 04:46:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/567943002/20001

[commit-bot: I haz the power, 2014-09-15 05:20:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-15 05:20:57]

Try jobs failed on following builders:
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)

[MRV, 2014-09-15 05:47:19]

The CQ bit was checked by mohan.reddy@samsung.com

[commit-bot: I haz the power, 2014-09-15 05:48:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/567943002/20001

[commit-bot: I haz the power, 2014-09-15 06:21:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-15 06:21:38]

Try jobs failed on following builders:
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[MRV, 2014-09-15 06:43:23]

The CQ bit was checked by mohan.reddy@samsung.com

[commit-bot: I haz the power, 2014-09-15 06:44:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/567943002/40001

[commit-bot: I haz the power, 2014-09-15 07:18:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-15 07:18:18]

Try jobs failed on following builders:
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)

[MRV, 2014-09-17 05:44:15]

The CQ bit was checked by mohan.reddy@samsung.com

[commit-bot: I haz the power, 2014-09-17 05:44:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/567943002/80001

[commit-bot: I haz the power, 2014-09-17 08:01:56]

Committed patchset #5 (id:80001) as 67cc6ee506d309a2fe83215d85266c667f1e986c

[commit-bot: I haz the power, 2014-09-17 08:02:34]

Patchset 5 (id:??) landed as
https://crrev.com/371ad91448d53434c2de797eb875c332d4b0a001
Cr-Commit-Position: refs/heads/master@{#295238}