content/browser/devtools/devtools_tracing_handler.h - Issue 567943002: Refactoring the weak_ptr_factory order content/browser folder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/devtools_tracing_handler.h

Issue 567943002: Refactoring the weak_ptr_factory order content/browser folder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Resolving swarming errors Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/compositor/gpu_process_transport_factory.cc ('k') | content/browser/devtools/devtools_tracing_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/devtools_tracing_handler.h

diff --git a/content/browser/devtools/devtools_tracing_handler.h b/content/browser/devtools/devtools_tracing_handler.h

index 31ba2d63ffb29d802e70fb93b29a9e08ba8ad3ab..9727466b14d0d70586b990b964b55a75b655ceac 100644

--- a/content/browser/devtools/devtools_tracing_handler.h

+++ b/content/browser/devtools/devtools_tracing_handler.h

@@ -54,7 +54,6 @@ class DevToolsTracingHandler : public DevToolsProtocol::Handler {

void DisableRecording(bool abort);

- base::WeakPtrFactory<DevToolsTracingHandler> weak_factory_;

scoped_ptr<base::Timer> buffer_usage_poll_timer_;

Target target_;

bool is_recording_;

@@ -63,6 +62,8 @@ class DevToolsTracingHandler : public DevToolsProtocol::Handler {

static const double kDefaultReportingInterval;

static const double kMinimumReportingInterval;

+ base::WeakPtrFactory<DevToolsTracingHandler> weak_factory_;

DISALLOW_COPY_AND_ASSIGN(DevToolsTracingHandler);

};