content/browser/frame_host/navigation_entry_screenshot_manager.h - Issue 567943002: Refactoring the weak_ptr_factory order content/browser folder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_entry_screenshot_manager.h

Issue 567943002: Refactoring the weak_ptr_factory order content/browser folder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Resolving swarming errors Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/devtools_tracing_handler.cc ('k') | content/browser/frame_host/navigation_entry_screenshot_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_entry_screenshot_manager.h

diff --git a/content/browser/frame_host/navigation_entry_screenshot_manager.h b/content/browser/frame_host/navigation_entry_screenshot_manager.h

index 072d6fd4a7fe19a1111acdb6b2e5c6c470f92285..21c78f18e62921a37ba9734c410407b997942edf 100644

--- a/content/browser/frame_host/navigation_entry_screenshot_manager.h

+++ b/content/browser/frame_host/navigation_entry_screenshot_manager.h

@@ -74,14 +74,14 @@ class CONTENT_EXPORT NavigationEntryScreenshotManager {

// The navigation controller that owns this screenshot-manager.

NavigationControllerImpl* owner_;

+ base::Time last_screenshot_time_;

+ int min_screenshot_interval_ms_;

// Taking a screenshot and encoding them can be async. So use a weakptr for

// the callback to make sure that the screenshot/encoding completion callback

// does not trigger on a destroyed NavigationEntryScreenshotManager.

base::WeakPtrFactory<NavigationEntryScreenshotManager> screenshot_factory_;

- base::Time last_screenshot_time_;

- int min_screenshot_interval_ms_;

DISALLOW_COPY_AND_ASSIGN(NavigationEntryScreenshotManager);

};