content/browser/devtools/devtools_tracing_handler.cc - Issue 567943002: Refactoring the weak_ptr_factory order content/browser folder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/devtools_tracing_handler.cc

Issue 567943002: Refactoring the weak_ptr_factory order content/browser folder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Resolving swarming errors Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/devtools_tracing_handler.h ('k') | content/browser/frame_host/navigation_entry_screenshot_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/devtools_tracing_handler.cc

diff --git a/content/browser/devtools/devtools_tracing_handler.cc b/content/browser/devtools/devtools_tracing_handler.cc

index 30f13d160027b65478b0083b35b8789765c30e65..7c3ceff2ed2e0bec0e0a9668d3ffe76c4321f9a5 100644

--- a/content/browser/devtools/devtools_tracing_handler.cc

+++ b/content/browser/devtools/devtools_tracing_handler.cc

@@ -56,7 +56,7 @@ const double DevToolsTracingHandler::kMinimumReportingInterval = 250.0;

DevToolsTracingHandler::DevToolsTracingHandler(

DevToolsTracingHandler::Target target)

- : weak_factory_(this), target_(target), is_recording_(false) {

+ : target_(target), is_recording_(false), weak_factory_(this) {

RegisterCommandHandler(devtools::Tracing::start::kName,

base::Bind(&DevToolsTracingHandler::OnStart,

base::Unretained(this)));