Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 567923002: Refactoring the weak_ptr_factory order in content/browser/renderer_host (Closed)

Created:
6 years, 3 months ago by MRV
Modified:
6 years, 3 months ago
Reviewers:
Avi (use Gerrit)
CC:
lgombos
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Refactoring the weak_ptr_factory order in content/browser/renderer_host Changing in the intialization order of WeakPtrFactory such that all member variables should appear before the WeakPtrFactory to ensure that any WeakPtrs to Controller are invalidated before its members variable's destructors are executed, rendering them invalid. BUG=303818 Committed: https://crrev.com/eef1b5914f37b0fb0edbd1c340a60332d5453453 Cr-Commit-Position: refs/heads/master@{#294637}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M content/browser/renderer_host/compositor_resize_lock_aura.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/compositor_resize_lock_aura.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/socket_stream_dispatcher_host.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/socket_stream_dispatcher_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
MRV
PTAL
6 years, 3 months ago (2014-09-12 06:29:59 UTC) #2
Avi (use Gerrit)
lgtm stampity stamp
6 years, 3 months ago (2014-09-12 15:31:35 UTC) #3
MRV
On 2014/09/12 15:31:35, Avi wrote: > lgtm > > stampity stamp Dear mr.avi.. thanks for ...
6 years, 3 months ago (2014-09-12 18:13:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/567923002/1
6 years, 3 months ago (2014-09-12 18:19:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6f559b2941bbe4fedc4d73f7fbf9ea9fd6878105
6 years, 3 months ago (2014-09-12 19:44:31 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 19:50:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eef1b5914f37b0fb0edbd1c340a60332d5453453
Cr-Commit-Position: refs/heads/master@{#294637}

Powered by Google App Engine
This is Rietveld 408576698