content/browser/renderer_host/render_view_host_impl.h - Issue 567923002: Refactoring the weak_ptr_factory order in content/browser/renderer_host

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_impl.h

Issue 567923002: Refactoring the weak_ptr_factory order in content/browser/renderer_host (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/compositor_resize_lock_aura.cc ('k') | content/browser/renderer_host/render_view_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_view_host_impl.h

diff --git a/content/browser/renderer_host/render_view_host_impl.h b/content/browser/renderer_host/render_view_host_impl.h

index 954046b410798d3c87a4be8b0e112b3f47d3b32e..3b9967898df2bd722f2dbb2f6f057f551dd80a1f 100644

--- a/content/browser/renderer_host/render_view_host_impl.h

+++ b/content/browser/renderer_host/render_view_host_impl.h

@@ -526,8 +526,6 @@ class CONTENT_EXPORT RenderViewHostImpl

// TODO(nasko): Move to RenderFrameHost, as this is per-frame state.

base::Closure pending_shutdown_on_swap_out_;

- base::WeakPtrFactory<RenderViewHostImpl> weak_factory_;

// True if the current focused element is editable.

bool is_focused_element_editable_;

@@ -538,6 +536,8 @@ class CONTENT_EXPORT RenderViewHostImpl

bool updating_web_preferences_;

+ base::WeakPtrFactory<RenderViewHostImpl> weak_factory_;

DISALLOW_COPY_AND_ASSIGN(RenderViewHostImpl);

};