content/browser/renderer_host/render_widget_host_view_android.cc - Issue 567923002: Refactoring the weak_ptr_factory order in content/browser/renderer_host

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 567923002: Refactoring the weak_ptr_factory order in content/browser/renderer_host (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_android.h ('k') | content/browser/renderer_host/socket_stream_dispatcher_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_android.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc

index e7a0cb248fe04b4d9e7b1b645e4bed702f0bfb46..9ccfa6ccc0491fcc4fae669b07b4fc8aa996463a 100644

--- a/content/browser/renderer_host/render_widget_host_view_android.cc

+++ b/content/browser/renderer_host/render_widget_host_view_android.cc

@@ -273,7 +273,6 @@ RenderWidgetHostViewAndroid::RenderWidgetHostViewAndroid(

ime_adapter_android_(this),

cached_background_color_(SK_ColorWHITE),

last_output_surface_id_(kUndefinedOutputSurfaceId),

- weak_ptr_factory_(this),

overscroll_effect_enabled_(

!base::CommandLine::ForCurrentProcess()->HasSwitch(

switches::kDisableOverscrollEdgeEffect)),

@@ -287,7 +286,8 @@ RenderWidgetHostViewAndroid::RenderWidgetHostViewAndroid(

widget_host->GetRoutingID()) != NULL),

frame_evictor_(new DelegatedFrameEvictor(this)),

locks_on_frame_count_(0),

- observing_root_window_(false) {

+ observing_root_window_(false),

+ weak_ptr_factory_(this) {

host_->SetView(this);

SetContentViewCore(content_view_core);

ImageTransportFactoryAndroid::AddObserver(this);