content/browser/renderer_host/render_view_host_impl.cc - Issue 567923002: Refactoring the weak_ptr_factory order in content/browser/renderer_host

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 567923002: Refactoring the weak_ptr_factory order in content/browser/renderer_host (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.h ('k') | content/browser/renderer_host/render_widget_host_view_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_view_host_impl.cc

diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc

index 42707c47fa837ed4338190f5467796b0ecc890ef..8f497f715c6ac81cb9593525e236ba4d39698a69 100644

--- a/content/browser/renderer_host/render_view_host_impl.cc

+++ b/content/browser/renderer_host/render_view_host_impl.cc

@@ -193,9 +193,9 @@ RenderViewHostImpl::RenderViewHostImpl(

sudden_termination_allowed_(false),

render_view_termination_status_(base::TERMINATION_STATUS_STILL_RUNNING),

virtual_keyboard_requested_(false),

- weak_factory_(this),

is_focused_element_editable_(false),

- updating_web_preferences_(false) {

+ updating_web_preferences_(false),

+ weak_factory_(this) {

DCHECK(instance_.get());

CHECK(delegate_); // http://crbug.com/82827