Rename Cronet AsyncUrlRequestXYZ interfaces into UrlRequestXYZ.

Rename Cronet AsyncUrlRequestXYZ interfaces into UrlRequestXYZ.

BUG=409926
Committed: https://crrev.com/5cc0fb538acd46e5f635d048a08e6d4416f94aa3
Cr-Commit-Position: refs/heads/master@{#294863}

[mef, 2014-09-15 15:58:14]

mef@chromium.org changed reviewers:
+ clm@google.com, mmenke@chromium.org, xunjieli@chromium.org

[mef, 2014-09-15 15:58:14]

Please take a look. This is a followup to
https://codereview.chromium.org/520093002/ to address comments added after
landing.

[mmenke, 2014-09-15 16:10:55]

LGTM

https://codereview.chromium.org/566833003/diff/1/components/cronet/android/ja...
File components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java
(right):

https://codereview.chromium.org/566833003/diff/1/components/cronet/android/ja...
components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java:8: *
Url request using Chromium HTTP stack implementation.
nit:  UrlRequest, maybe?

https://codereview.chromium.org/566833003/diff/1/components/cronet/android/ja...
File
components/cronet/android/java/src/org/chromium/net/CronetUrlRequestFactory.java
(right):

https://codereview.chromium.org/566833003/diff/1/components/cronet/android/ja...
components/cronet/android/java/src/org/chromium/net/CronetUrlRequestFactory.java:4:
package org.chromium.net;
nit:  Blank line before package

https://codereview.chromium.org/566833003/diff/1/components/cronet/android/ja...
components/cronet/android/java/src/org/chromium/net/CronetUrlRequestFactory.java:15:
CronetUrlRequest request = new CronetUrlRequest();
Any reason not to just use:

return new CronetUrlRequest(); ?

[mef, 2014-09-15 16:17:59]

thanks!

https://codereview.chromium.org/566833003/diff/1/components/cronet/android/ja...
File components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java
(right):

https://codereview.chromium.org/566833003/diff/1/components/cronet/android/ja...
components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java:8: *
Url request using Chromium HTTP stack implementation.
On 2014/09/15 16:10:55, mmenke wrote:
> nit:  UrlRequest, maybe?

Done.

https://codereview.chromium.org/566833003/diff/1/components/cronet/android/ja...
File
components/cronet/android/java/src/org/chromium/net/CronetUrlRequestFactory.java
(right):

https://codereview.chromium.org/566833003/diff/1/components/cronet/android/ja...
components/cronet/android/java/src/org/chromium/net/CronetUrlRequestFactory.java:4:
package org.chromium.net;
On 2014/09/15 16:10:55, mmenke wrote:
> nit:  Blank line before package

Done.

https://codereview.chromium.org/566833003/diff/1/components/cronet/android/ja...
components/cronet/android/java/src/org/chromium/net/CronetUrlRequestFactory.java:11:
public class CronetUrlRequestFactory implements UrlRequestFactory {
I've named this 'CronetUrlRequest[Factory]' to aviod naming collision with
existing ChromiumUrlRequest[Factory].

Similarly, I'm thinking about adding PlatformUrlRequest[Factory] for
HttpUrlConnection-based implementation. WDYT?

https://codereview.chromium.org/566833003/diff/1/components/cronet/android/ja...
components/cronet/android/java/src/org/chromium/net/CronetUrlRequestFactory.java:15:
CronetUrlRequest request = new CronetUrlRequest();
On 2014/09/15 16:10:55, mmenke wrote:
> Any reason not to just use:
> 
> return new CronetUrlRequest(); ?

Done.

[mef, 2014-09-15 16:18:03]

thanks!

[mmenke, 2014-09-15 16:23:33]

https://codereview.chromium.org/566833003/diff/1/components/cronet/android/ja...
File
components/cronet/android/java/src/org/chromium/net/CronetUrlRequestFactory.java
(right):

https://codereview.chromium.org/566833003/diff/1/components/cronet/android/ja...
components/cronet/android/java/src/org/chromium/net/CronetUrlRequestFactory.java:11:
public class CronetUrlRequestFactory implements UrlRequestFactory {
On 2014/09/15 16:17:59, mef wrote:
> I've named this 'CronetUrlRequest[Factory]' to aviod naming collision with
> existing ChromiumUrlRequest[Factory].
> 
> Similarly, I'm thinking about adding PlatformUrlRequest[Factory] for
> HttpUrlConnection-based implementation. WDYT?

I think we may want to combine the two factories, eventually.

Having both HttpUrlRequest/ChromiumUrlRequest and UrlRequest/CronetUrlRequest is
really ugly.  I'd think we should aim to have more consistent names, though may
require a couple patches to coordinate the change with embedders.  I don't think
we should worry about all of that now, however.

Maybe call the first two BlockingUrlRequest/CronetBlockingUrlRequest?

[mef, 2014-09-15 17:05:16]

The CQ bit was checked by mef@chromium.org

[commit-bot: I haz the power, 2014-09-15 17:18:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/566833003/20001

[commit-bot: I haz the power, 2014-09-15 19:14:02]

Committed patchset #2 (id:20001) as 754e086056082c5ceaf891ada51eb4028512c9db

[commit-bot: I haz the power, 2014-09-15 19:16:54]

Patchset 2 (id:??) landed as
https://crrev.com/5cc0fb538acd46e5f635d048a08e6d4416f94aa3
Cr-Commit-Position: refs/heads/master@{#294863}