Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: components/cronet/android/java/src/org/chromium/net/UrlRequest.java

Issue 566833003: Rename Cronet AsyncUrlRequestXYZ interfaces into UrlRequestXYZ. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/java/src/org/chromium/net/UrlRequest.java
diff --git a/components/cronet/android/java/src/org/chromium/net/AsyncUrlRequest.java b/components/cronet/android/java/src/org/chromium/net/UrlRequest.java
similarity index 94%
rename from components/cronet/android/java/src/org/chromium/net/AsyncUrlRequest.java
rename to components/cronet/android/java/src/org/chromium/net/UrlRequest.java
index 459af25ba7e78a0d04535a2a1b1b4d707164dd6b..57a0b439101592235c74d522962acc76dd9dba37 100644
--- a/components/cronet/android/java/src/org/chromium/net/AsyncUrlRequest.java
+++ b/components/cronet/android/java/src/org/chromium/net/UrlRequest.java
@@ -8,7 +8,7 @@ package org.chromium.net;
* HTTP request (GET, PUT or POST).
* Note: All methods must be called on the Executor passed in during creation.
*/
-public abstract interface AsyncUrlRequest {
+public interface UrlRequest {
/**
* More setters go here. They may only be called before start (Maybe
* also allow during redirects). Could optionally instead use arguments
@@ -21,7 +21,7 @@ public abstract interface AsyncUrlRequest {
* <p>The default when this method is not called is "GET" if the request has
* no body or "POST" if it does.
*
- * @param method Either "POST" or "PUT".
+ * @param method "GET", "HEAD", "DELETE", "POST" or "PUT".
*/
public void setHttpMethod(String method);
@@ -37,7 +37,7 @@ public abstract interface AsyncUrlRequest {
* Starts the request, all callbacks go to listener.
* @param listener
*/
- public void start(AsyncUrlRequestListener listener);
+ public void start(UrlRequestListener listener);
/**
* Can be called at any time.

Powered by Google App Engine
This is Rietveld 408576698