Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: components/cronet/android/java/src/org/chromium/net/UrlRequestFactory.java

Issue 566833003: Rename Cronet AsyncUrlRequestXYZ interfaces into UrlRequestXYZ. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/java/src/org/chromium/net/UrlRequestFactory.java
diff --git a/components/cronet/android/java/src/org/chromium/net/AsyncUrlRequestFactory.java b/components/cronet/android/java/src/org/chromium/net/UrlRequestFactory.java
similarity index 61%
rename from components/cronet/android/java/src/org/chromium/net/AsyncUrlRequestFactory.java
rename to components/cronet/android/java/src/org/chromium/net/UrlRequestFactory.java
index f1ce8295a46b553bb990b5e490b6239a1ab39696..2b08e7d99472e8a07a813d78446f6f608797ebb8 100644
--- a/components/cronet/android/java/src/org/chromium/net/AsyncUrlRequestFactory.java
+++ b/components/cronet/android/java/src/org/chromium/net/UrlRequestFactory.java
@@ -7,20 +7,20 @@ package org.chromium.net;
import java.util.concurrent.Executor;
/**
- * A factory for {@link AsyncUrlRequest}'s, which uses the best HTTP stack
+ * A factory for {@link UrlRequest}'s, which uses the best HTTP stack
* available on the current platform.
*/
-public abstract class AsyncUrlRequestFactory {
+public interface UrlRequestFactory {
/**
- * Creates an AsyncUrlRequest object. All AsyncUrlRequest functions must
+ * Creates an UrlRequest object. All UrlRequest functions must
* be called on the Executor's thread, and all callbacks will be called
* on the Executor's thread as well.
- * createAsyncRequest itself may be called on any thread.
+ * createRequest itself may be called on any thread.
* @param url URL for the request.
* @param listener Callback interface that gets called on different events.
* @param executor Executor on which all callbacks will be called.
* @return new request.
*/
- public abstract AsyncUrlRequest createAsyncRequest(String url,
- AsyncUrlRequestListener listener, Executor executor);
+ public abstract UrlRequest createRequest(String url,
+ UrlRequestListener listener, Executor executor);
}

Powered by Google App Engine
This is Rietveld 408576698