Rename Cronet AsyncUrlRequestXYZ interfaces into UrlRequestXYZ.

components/cronet/android/java/src/org/chromium/net/CronetUrlRequestFactory.java

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+package org.chromium.net;

[mmenke, 2014/09/15 16:10:55]

nit:  Blank line before package

[mef, 2014/09/15 16:17:59]

Done.

+
+import java.util.concurrent.Executor;
+
+/**
+ * Url request factory using Chromium HTTP stack implementation.
+ */
+public class CronetUrlRequestFactory implements UrlRequestFactory {

[mef, 2014/09/15 16:17:59]

I've named this 'CronetUrlRequest[Factory]' to aviod naming collision with
existing ChromiumUrlRequest[Factory].

Similarly, I'm thinking about adding PlatformUrlRequest[Factory] for
HttpUrlConnection-based implementation. WDYT?

[mmenke, 2014/09/15 16:23:32]

I think we may want to combine the two factories, eventually.

Having both HttpUrlRequest/ChromiumUrlRequest and UrlRequest/CronetUrlRequest is
really ugly.  I'd think we should aim to have more consistent names, though may
require a couple patches to coordinate the change with embedders.  I don't think
we should worry about all of that now, however.

Maybe call the first two BlockingUrlRequest/CronetBlockingUrlRequest?

+    @Override
+    public UrlRequest createRequest(String url, UrlRequestListener listener,
+                                    Executor executor) {
+        CronetUrlRequest request = new CronetUrlRequest();

[mmenke, 2014/09/15 16:10:55]

Any reason not to just use:

return new CronetUrlRequest(); ?

[mef, 2014/09/15 16:17:59]

Done.

+        return request;
+    }
+}