Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 565733003: Put back allow_circular_includes_from in GN build. (Closed)

Created:
6 years, 3 months ago by brettw
Modified:
6 years, 3 months ago
Reviewers:
jamesr
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Put back allow_circular_includes_from in GN build. A previous patch commented these out, but this ended up not being necessary. Put them back. Committed: https://crrev.com/69efd071162c9be1fd6a7c46437ba852c1edf666 Cr-Commit-Position: refs/heads/master@{#294460}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M content/public/browser/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/renderer/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/utility/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
brettw
6 years, 3 months ago (2014-09-11 19:28:09 UTC) #2
jamesr
lgtm
6 years, 3 months ago (2014-09-11 19:29:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565733003/1
6 years, 3 months ago (2014-09-11 19:56:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as ca19ffd42d074f3b3e9533a4cd1a0915f5ee9352
6 years, 3 months ago (2014-09-11 20:39:17 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 20:51:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/69efd071162c9be1fd6a7c46437ba852c1edf666
Cr-Commit-Position: refs/heads/master@{#294460}

Powered by Google App Engine
This is Rietveld 408576698