Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2088)

Unified Diff: content/public/browser/BUILD.gn

Issue 565733003: Put back allow_circular_includes_from in GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/public/renderer/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/BUILD.gn
diff --git a/content/public/browser/BUILD.gn b/content/public/browser/BUILD.gn
index 60330986506a8ff2e3a9a4b35e9d902823a3efb4..8d3052389e804fe35161e747edd5289afd4549a8 100644
--- a/content/public/browser/BUILD.gn
+++ b/content/public/browser/BUILD.gn
@@ -54,8 +54,7 @@ source_set("browser_sources") {
allow_circular_includes_from = [
# This target is a pair with content/browser. They always go together and
# include headers from each other.
- # TODO(brettw) enable this when this permits non-dependent targets.
- #"//content/browser",
+ "//content/browser",
]
# We expose skia headers in the public API.
« no previous file with comments | « no previous file | content/public/renderer/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698