Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Side by Side Diff: content/public/browser/BUILD.gn

Issue 565733003: Put back allow_circular_includes_from in GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/public/renderer/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//content/browser/browser.gni") 5 import("//content/browser/browser.gni")
6 import("//build/config/ui.gni") 6 import("//build/config/ui.gni")
7 7
8 # See //content/BUILD.gn for how this works. 8 # See //content/BUILD.gn for how this works.
9 group("browser") { 9 group("browser") {
10 if (is_component_build) { 10 if (is_component_build) {
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 "//net", 47 "//net",
48 "//skia", 48 "//skia",
49 "//ui/accessibility", 49 "//ui/accessibility",
50 "//ui/base", 50 "//ui/base",
51 "//ui/events", 51 "//ui/events",
52 ] 52 ]
53 53
54 allow_circular_includes_from = [ 54 allow_circular_includes_from = [
55 # This target is a pair with content/browser. They always go together and 55 # This target is a pair with content/browser. They always go together and
56 # include headers from each other. 56 # include headers from each other.
57 # TODO(brettw) enable this when this permits non-dependent targets. 57 "//content/browser",
58 #"//content/browser",
59 ] 58 ]
60 59
61 # We expose skia headers in the public API. 60 # We expose skia headers in the public API.
62 forward_dependent_configs_from = [ "//skia" ] 61 forward_dependent_configs_from = [ "//skia" ]
63 } 62 }
OLDNEW
« no previous file with comments | « no previous file | content/public/renderer/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698