Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: content/public/renderer/BUILD.gn

Issue 565733003: Put back allow_circular_includes_from in GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/public/browser/BUILD.gn ('k') | content/public/utility/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 import("//content/renderer/renderer.gni") 6 import("//content/renderer/renderer.gni")
7 7
8 # See //content/BUILD.gn for how this works. 8 # See //content/BUILD.gn for how this works.
9 group("renderer") { 9 group("renderer") {
10 if (is_component_build) { 10 if (is_component_build) {
(...skipping 21 matching lines...) Expand all
32 "//third_party/libjingle", 32 "//third_party/libjingle",
33 "//third_party/WebKit/public:blink_headers", 33 "//third_party/WebKit/public:blink_headers",
34 "//third_party/widevine/cdm:version_h", 34 "//third_party/widevine/cdm:version_h",
35 "//ui/gfx", 35 "//ui/gfx",
36 "//v8", 36 "//v8",
37 ] 37 ]
38 38
39 allow_circular_includes_from = [ 39 allow_circular_includes_from = [
40 # This target is a pair with content/renderer. They always go together and 40 # This target is a pair with content/renderer. They always go together and
41 # include headers from each other. 41 # include headers from each other.
42 # TODO(brettw) enable this when this permits non-dependent targets. 42 "//content/renderer",
43 #"//content/renderer",
44 ] 43 ]
45 44
46 if (enable_webrtc) { 45 if (enable_webrtc) {
47 sources += rebase_path( 46 sources += rebase_path(
48 content_renderer_gypi_values.public_renderer_webrtc_sources, 47 content_renderer_gypi_values.public_renderer_webrtc_sources,
49 ".", "//content") 48 ".", "//content")
50 } 49 }
51 } 50 }
OLDNEW
« no previous file with comments | « content/public/browser/BUILD.gn ('k') | content/public/utility/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698