Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 563563002: make set3DMask virtual, so we can safely notify the shadercontext (Closed)

Created:
6 years, 3 months ago by reed1
Modified:
6 years, 3 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

make set3DMask virtual, so we can safely notify the shadercontext also boost preallocated storage to account for this combo of bitmapshader + emboss + colorfilter BUG=skia: Committed: https://skia.googlesource.com/skia/+/cc0e3110bde60201882a2c512a5cdd73c838f351

Patch Set 1 #

Patch Set 2 : ad gm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -11 lines) Patch
A gm/emboss.cpp View 1 1 chunk +61 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkShader.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/core/SkBitmapProcShader.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBlitter.cpp View 5 chunks +10 lines, -10 lines 0 comments Download
M src/core/SkFilterShader.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
reed1
will make a real gm before submitting
6 years, 3 months ago (2014-09-10 15:13:38 UTC) #2
djsollen
lg pending GM
6 years, 3 months ago (2014-09-10 17:01:07 UTC) #3
reed1
ptal
6 years, 3 months ago (2014-09-10 17:11:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/563563002/20001
6 years, 3 months ago (2014-09-10 17:11:52 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 3 months ago (2014-09-10 17:11:53 UTC) #7
djsollen
lgtm
6 years, 3 months ago (2014-09-10 17:12:50 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 17:20:29 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as cc0e3110bde60201882a2c512a5cdd73c838f351

Powered by Google App Engine
This is Rietveld 408576698