chrome/test/base/chrome_render_view_test.h - Issue 563313004: [Password Manager] Unfriend PasswordAutofillAgentTest from PasswordAutofillAgent (clean-up).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/base/chrome_render_view_test.h

Issue 563313004: [Password Manager] Unfriend PasswordAutofillAgentTest from PasswordAutofillAgent (clean-up). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated review comments. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/autofill/password_autofill_agent_browsertest.cc ('K') | « chrome/renderer/autofill/password_generation_agent_browsertest.cc ('k') | chrome/test/base/chrome_render_view_test.cc » ('j') | chrome/test/data/password/form_with_only_password_field.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/base/chrome_render_view_test.h

diff --git a/chrome/test/base/chrome_render_view_test.h b/chrome/test/base/chrome_render_view_test.h

index 19ee8d2869facb5a5993d440e4ca24b24d4c60a4..c5ffb8f654122de3d77d5320133520607668bfeb 100644

--- a/chrome/test/base/chrome_render_view_test.h

+++ b/chrome/test/base/chrome_render_view_test.h

@@ -12,7 +12,7 @@

#include "content/public/test/render_view_test.h"

namespace autofill {

-class AutofillAgent;

+class TestAutofillAgent;

class TestPasswordAutofillAgent;

class TestPasswordGenerationAgent;

}

@@ -39,7 +39,7 @@ class ChromeRenderViewTest : public content::RenderViewTest {

autofill::TestPasswordAutofillAgent* password_autofill_;

Ilya Sherman 2014/09/18 18:45:52 While you're here, please rename this to "password

Pritam Nikam 2014/09/19 11:08:02 Done.

autofill::TestPasswordGenerationAgent* password_generation_;

- autofill::AutofillAgent* autofill_agent_;

+ autofill::TestAutofillAgent* autofill_agent_;

// Naked pointer as ownership is with content::RenderViewTest::render_thread_.

ChromeMockRenderThread* chrome_render_thread_;