Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Side by Side Diff: chrome/test/base/chrome_render_view_test.h

Issue 563313004: [Password Manager] Unfriend PasswordAutofillAgentTest from PasswordAutofillAgent (clean-up). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated review comments. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_TEST_BASE_CHROME_RENDER_VIEW_TEST_H_ 5 #ifndef CHROME_TEST_BASE_CHROME_RENDER_VIEW_TEST_H_
6 #define CHROME_TEST_BASE_CHROME_RENDER_VIEW_TEST_H_ 6 #define CHROME_TEST_BASE_CHROME_RENDER_VIEW_TEST_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
11 #include "chrome/renderer/chrome_mock_render_thread.h" 11 #include "chrome/renderer/chrome_mock_render_thread.h"
12 #include "content/public/test/render_view_test.h" 12 #include "content/public/test/render_view_test.h"
13 13
14 namespace autofill { 14 namespace autofill {
15 class AutofillAgent; 15 class TestAutofillAgent;
16 class TestPasswordAutofillAgent; 16 class TestPasswordAutofillAgent;
17 class TestPasswordGenerationAgent; 17 class TestPasswordGenerationAgent;
18 } 18 }
19 19
20 namespace extensions { 20 namespace extensions {
21 class DispatcherDelegate; 21 class DispatcherDelegate;
22 } 22 }
23 23
24 class ChromeRenderViewTest : public content::RenderViewTest { 24 class ChromeRenderViewTest : public content::RenderViewTest {
25 public: 25 public:
26 ChromeRenderViewTest(); 26 ChromeRenderViewTest();
27 virtual ~ChromeRenderViewTest(); 27 virtual ~ChromeRenderViewTest();
28 28
29 protected: 29 protected:
30 // testing::Test 30 // testing::Test
31 virtual void SetUp() OVERRIDE; 31 virtual void SetUp() OVERRIDE;
32 virtual void TearDown() OVERRIDE; 32 virtual void TearDown() OVERRIDE;
33 virtual content::ContentClient* CreateContentClient() OVERRIDE; 33 virtual content::ContentClient* CreateContentClient() OVERRIDE;
34 virtual content::ContentBrowserClient* CreateContentBrowserClient() OVERRIDE; 34 virtual content::ContentBrowserClient* CreateContentBrowserClient() OVERRIDE;
35 virtual content::ContentRendererClient* 35 virtual content::ContentRendererClient*
36 CreateContentRendererClient() OVERRIDE; 36 CreateContentRendererClient() OVERRIDE;
37 37
38 scoped_ptr<extensions::DispatcherDelegate> extension_dispatcher_delegate_; 38 scoped_ptr<extensions::DispatcherDelegate> extension_dispatcher_delegate_;
39 39
40 autofill::TestPasswordAutofillAgent* password_autofill_; 40 autofill::TestPasswordAutofillAgent* password_autofill_;
Ilya Sherman 2014/09/18 18:45:52 While you're here, please rename this to "password
Pritam Nikam 2014/09/19 11:08:02 Done.
41 autofill::TestPasswordGenerationAgent* password_generation_; 41 autofill::TestPasswordGenerationAgent* password_generation_;
42 autofill::AutofillAgent* autofill_agent_; 42 autofill::TestAutofillAgent* autofill_agent_;
43 43
44 // Naked pointer as ownership is with content::RenderViewTest::render_thread_. 44 // Naked pointer as ownership is with content::RenderViewTest::render_thread_.
45 ChromeMockRenderThread* chrome_render_thread_; 45 ChromeMockRenderThread* chrome_render_thread_;
46 }; 46 };
47 47
48 #endif // CHROME_TEST_BASE_CHROME_RENDER_VIEW_TEST_H_ 48 #endif // CHROME_TEST_BASE_CHROME_RENDER_VIEW_TEST_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698