chrome/test/base/chrome_render_view_test.cc - Issue 563313004: [Password Manager] Unfriend PasswordAutofillAgentTest from PasswordAutofillAgent (clean-up).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/base/chrome_render_view_test.cc

Issue 563313004: [Password Manager] Unfriend PasswordAutofillAgentTest from PasswordAutofillAgent (clean-up). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated review comments. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/base/chrome_render_view_test.h ('K') | « chrome/test/base/chrome_render_view_test.h ('k') | chrome/test/data/password/form_with_only_password_field.html » ('j') | chrome/test/data/password/form_with_only_password_field.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/base/chrome_render_view_test.cc

diff --git a/chrome/test/base/chrome_render_view_test.cc b/chrome/test/base/chrome_render_view_test.cc

index 92425b1b667f476545c10c969009c12bb8344b58..c1d7dfd1f495911772f2b02d39457c4e1d4722e0 100644

--- a/chrome/test/base/chrome_render_view_test.cc

+++ b/chrome/test/base/chrome_render_view_test.cc

@@ -12,8 +12,8 @@

#include "chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.h"

#include "chrome/renderer/spellchecker/spellcheck.h"

#include "chrome/test/base/chrome_unit_test_suite.h"

-#include "components/autofill/content/renderer/autofill_agent.h"

#include "components/autofill/content/renderer/password_autofill_agent.h"

+#include "components/autofill/content/renderer/test_autofill_agent.h"

#include "components/autofill/content/renderer/test_password_autofill_agent.h"

#include "components/autofill/content/renderer/test_password_generation_agent.h"

#include "content/public/browser/native_web_keyboard_event.h"

@@ -38,9 +38,9 @@ using blink::WebScriptController;

using blink::WebScriptSource;

using blink::WebString;

using blink::WebURLRequest;

-using autofill::AutofillAgent;

using autofill::PasswordAutofillAgent;

using autofill::PasswordGenerationAgent;

+using autofill::TestAutofillAgent;

ChromeRenderViewTest::ChromeRenderViewTest()

: password_autofill_(NULL),

@@ -67,7 +67,7 @@ void ChromeRenderViewTest::SetUp() {

password_autofill_ = new autofill::TestPasswordAutofillAgent(view_);

password_generation_ = new autofill::TestPasswordGenerationAgent(view_);

autofill_agent_ =

- new AutofillAgent(view_, password_autofill_, password_generation_);

+ new TestAutofillAgent(view_, password_autofill_, password_generation_);

}

void ChromeRenderViewTest::TearDown() {