Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7194)

Unified Diff: chrome/renderer/autofill/password_generation_agent_browsertest.cc

Issue 563313004: [Password Manager] Unfriend PasswordAutofillAgentTest from PasswordAutofillAgent (clean-up). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated review comments. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/autofill/password_generation_agent_browsertest.cc
diff --git a/chrome/renderer/autofill/password_generation_agent_browsertest.cc b/chrome/renderer/autofill/password_generation_agent_browsertest.cc
index 60bdaa3efa8a9c77e86dc2d7997968038f342b55..417e6cf64a5a18619c5f615e4657ca71d68e5b98 100644
--- a/chrome/renderer/autofill/password_generation_agent_browsertest.cc
+++ b/chrome/renderer/autofill/password_generation_agent_browsertest.cc
@@ -8,7 +8,7 @@
#include "base/strings/utf_string_conversions.h"
#include "chrome/test/base/chrome_render_view_test.h"
#include "components/autofill/content/common/autofill_messages.h"
-#include "components/autofill/content/renderer/autofill_agent.h"
+#include "components/autofill/content/renderer/test_autofill_agent.h"
#include "components/autofill/content/renderer/test_password_generation_agent.h"
#include "components/autofill/core/common/form_data.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -200,8 +200,8 @@ TEST_F(PasswordGenerationAgentTest, EditingTest) {
base::string16 edited_password = base::ASCIIToUTF16("edited_password");
first_password_element.setValue(edited_password);
// Cast to WebAutofillClient where textFieldDidChange() is public.
- static_cast<blink::WebAutofillClient*>(autofill_agent_)->textFieldDidChange(
- first_password_element);
+ static_cast<blink::WebAutofillClient*>(autofill_agent_)
+ ->textFieldDidChange(first_password_element);
// textFieldDidChange posts a task, so we need to wait until it's been
// processed.
base::MessageLoop::current()->RunUntilIdle();
@@ -272,8 +272,8 @@ TEST_F(PasswordGenerationAgentTest, MaximumOfferSize) {
base::ASCIIToUTF16(
std::string(password_generation_->kMaximumOfferSize - 1, 'a')));
// Cast to WebAutofillClient where textFieldDidChange() is public.
- static_cast<blink::WebAutofillClient*>(autofill_agent_)->textFieldDidChange(
- first_password_element);
+ static_cast<blink::WebAutofillClient*>(autofill_agent_)
+ ->textFieldDidChange(first_password_element);
// textFieldDidChange posts a task, so we need to wait until it's been
// processed.
base::MessageLoop::current()->RunUntilIdle();
@@ -288,8 +288,8 @@ TEST_F(PasswordGenerationAgentTest, MaximumOfferSize) {
base::ASCIIToUTF16(
std::string(password_generation_->kMaximumOfferSize + 1, 'a')));
// Cast to WebAutofillClient where textFieldDidChange() is public.
- static_cast<blink::WebAutofillClient*>(autofill_agent_)->textFieldDidChange(
- first_password_element);
+ static_cast<blink::WebAutofillClient*>(autofill_agent_)
+ ->textFieldDidChange(first_password_element);
// textFieldDidChange posts a task, so we need to wait until it's been
// processed.
base::MessageLoop::current()->RunUntilIdle();
@@ -305,8 +305,8 @@ TEST_F(PasswordGenerationAgentTest, MaximumOfferSize) {
base::ASCIIToUTF16(
std::string(password_generation_->kMaximumOfferSize, 'a')));
// Cast to WebAutofillClient where textFieldDidChange() is public.
- static_cast<blink::WebAutofillClient*>(autofill_agent_)->textFieldDidChange(
- first_password_element);
+ static_cast<blink::WebAutofillClient*>(autofill_agent_)
+ ->textFieldDidChange(first_password_element);
// textFieldDidChange posts a task, so we need to wait until it's been
// processed.
base::MessageLoop::current()->RunUntilIdle();

Powered by Google App Engine
This is Rietveld 408576698