Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 562563002: Make some fields non-nullable in serial.mojom and data_stream.mojom. (Closed)

Created:
6 years, 3 months ago by Sam McNally
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, raymes
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make some fields non-nullable in serial.mojom and data_stream.mojom. This also removes some null checks for the now non-nullable fields. BUG=407683 Committed: https://crrev.com/da421fab9270e9fd48875f14e3ae9a001c6f0d77 Cr-Commit-Position: refs/heads/master@{#294277}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M device/serial/data_sink_receiver.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/serial/data_source_sender.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M device/serial/data_stream.mojom View 2 chunks +2 lines, -2 lines 0 comments Download
M device/serial/serial.mojom View 3 chunks +8 lines, -8 lines 0 comments Download
M extensions/renderer/api/serial/serial_api_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/renderer/resources/serial_service.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Sam McNally
6 years, 3 months ago (2014-09-10 08:07:11 UTC) #3
Ken Rockot(use gerrit already)
lgtm
6 years, 3 months ago (2014-09-10 16:32:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562563002/20001
6 years, 3 months ago (2014-09-10 23:50:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001) as d5d337f07bc4b224f4c9bdecb5429875cb4e939a
6 years, 3 months ago (2014-09-11 00:53:29 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 00:55:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da421fab9270e9fd48875f14e3ae9a001c6f0d77
Cr-Commit-Position: refs/heads/master@{#294277}

Powered by Google App Engine
This is Rietveld 408576698